Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Side by Side Diff: Source/core/svg/SVGAngleTearOff.cpp

Issue 303263008: [SVG2] Add support for the 'turn' unit in <angle>. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: hide the internals of SVGAngle Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 } 102 }
103 103
104 void SVGAngleTearOff::setValueAsString(const String& value, ExceptionState& exce ptionState) 104 void SVGAngleTearOff::setValueAsString(const String& value, ExceptionState& exce ptionState)
105 { 105 {
106 if (isImmutable()) { 106 if (isImmutable()) {
107 exceptionState.throwDOMException(NoModificationAllowedError, "The attrib ute is read-only."); 107 exceptionState.throwDOMException(NoModificationAllowedError, "The attrib ute is read-only.");
108 return; 108 return;
109 } 109 }
110 110
111 target()->setValueAsString(value, exceptionState); 111 target()->setValueAsString(value, exceptionState);
112
113 if (!exceptionState.hadException() && !isValidAngle()) {
114 exceptionState.throwDOMException(SyntaxError, "The value provided ('" + value + "') is invalid.");
fs 2014/06/10 11:13:30 Hmm, the "damage" has been done here already (stat
krit 2014/06/10 11:45:48 Does unknown unit type need to imply that we do no
Erik Dahlström (inactive) 2014/06/10 16:57:42 If we want to behave as if the "turn" unit wasn't
Erik Dahlström (inactive) 2014/06/10 16:57:42 Done.
115 return;
116 }
117
112 commitChange(); 118 commitChange();
113 } 119 }
114 120
115 } 121 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698