Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 303263006: Make sure end position of selection to delete editable (Closed)

Created:
6 years, 6 months ago by yosin_UTC9
Modified:
6 years, 6 months ago
Reviewers:
yoichio, Yuta Kitamura
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Make sure end position of selection to delete editable This patch makes sure DeleteSelectionCommand to work on both start and end positions of selection to delete editable, by adjusting end position to last editable position of highest editable root from start position and assertion for start position. Start position is editable when DeleteSelection command is invoked document.execCommand. Newly added assertion for start position will catch commands which call DeleteSelectionCommand with non-editable selection. BUG=361935 TEST=LayoutTests/editing/deleting/delete-selection-with-non-editable-end-crash.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175336

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, --1 lines) Patch
A LayoutTests/editing/deleting/delete-selection-with-non-editable-end-crash.html View 1 chunk +21 lines, -0 lines 0 comments Download
A + LayoutTests/editing/deleting/delete-selection-with-non-editable-end-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/editing/DeleteSelectionCommand.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yosin_UTC9
Could you review this patch? Thanks in advance. Note: Failure of " blink_android_compile_rel" isn't related ...
6 years, 6 months ago (2014-06-02 08:10:28 UTC) #1
Yuta Kitamura
lgtm
6 years, 6 months ago (2014-06-03 06:27:39 UTC) #2
yosin_UTC9
The CQ bit was checked by yosin@chromium.org
6 years, 6 months ago (2014-06-03 06:33:56 UTC) #3
yosin_UTC9
The CQ bit was checked by yosin@chromium.org
6 years, 6 months ago (2014-06-03 06:34:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/303263006/1
6 years, 6 months ago (2014-06-03 06:34:22 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 06:38:04 UTC) #6
Message was sent while issue was closed.
Change committed as 175336

Powered by Google App Engine
This is Rietveld 408576698