Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 303263005: Add Sample slide for Rectanizers (Closed)

Created:
6 years, 6 months ago by robertphillips
Modified:
6 years, 6 months ago
Reviewers:
jvanverth1, bsalomon
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : cleaned up #

Patch Set 3 : Make sure GPU-less build will compile #

Total comments: 2

Patch Set 4 : Fix printf parameter #

Patch Set 5 : Update to ToT #

Patch Set 6 : Fixing upload failure #

Patch Set 7 : comment change #

Patch Set 8 : comment change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -20 lines) Patch
M gyp/SampleApp.gyp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/GrPoint.h View 1 chunk +9 lines, -5 lines 0 comments Download
A samplecode/SampleRectanizer.cpp View 1 2 3 1 chunk +198 lines, -0 lines 0 comments Download
M src/gpu/GrRectanizer.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrRectanizer_pow2.h View 3 chunks +12 lines, -2 lines 0 comments Download
M src/gpu/GrRectanizer_pow2.cpp View 1 2 chunks +1 line, -7 lines 0 comments Download
M src/gpu/GrRectanizer_skyline.h View 1 2 3 4 5 6 7 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
robertphillips
6 years, 6 months ago (2014-05-30 15:36:26 UTC) #1
jvanverth1
lgtm, just one question: https://codereview.chromium.org/303263005/diff/40001/src/gpu/GrRectanizer_pow2.cpp File src/gpu/GrRectanizer_pow2.cpp (left): https://codereview.chromium.org/303263005/diff/40001/src/gpu/GrRectanizer_pow2.cpp#oldcode20 src/gpu/GrRectanizer_pow2.cpp:20: /* Why did you remove ...
6 years, 6 months ago (2014-05-30 18:03:01 UTC) #2
robertphillips
https://codereview.chromium.org/303263005/diff/40001/src/gpu/GrRectanizer_pow2.cpp File src/gpu/GrRectanizer_pow2.cpp (left): https://codereview.chromium.org/303263005/diff/40001/src/gpu/GrRectanizer_pow2.cpp#oldcode20 src/gpu/GrRectanizer_pow2.cpp:20: /* This approach doesn't use binary search. Also there ...
6 years, 6 months ago (2014-05-30 18:19:27 UTC) #3
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 6 months ago (2014-05-30 18:36:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/303263005/60001
6 years, 6 months ago (2014-05-30 18:37:10 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 18:37:13 UTC) #6
commit-bot: I haz the power
Failed to apply patch for src/gpu/GrRectanizer_skyline.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 6 months ago (2014-05-30 18:37:14 UTC) #7
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 6 months ago (2014-05-30 18:56:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/303263005/140001
6 years, 6 months ago (2014-05-30 18:57:37 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 18:57:43 UTC) #10
commit-bot: I haz the power
Presubmit check for 303263005-140001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 6 months ago (2014-05-30 18:57:44 UTC) #11
robertphillips
6 years, 6 months ago (2014-05-30 18:58:44 UTC) #12
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 6 months ago (2014-06-02 14:00:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/303263005/140001
6 years, 6 months ago (2014-06-02 14:00:43 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-02 14:00:46 UTC) #15
commit-bot: I haz the power
Presubmit check for 303263005-140001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 6 months ago (2014-06-02 14:00:47 UTC) #16
bsalomon
On 2014/06/02 14:00:47, I haz the power (commit-bot) wrote: > Presubmit check for 303263005-140001 failed ...
6 years, 6 months ago (2014-06-02 14:04:35 UTC) #17
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 6 months ago (2014-06-02 14:09:32 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/303263005/140001
6 years, 6 months ago (2014-06-02 14:09:45 UTC) #19
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 14:15:22 UTC) #20
Message was sent while issue was closed.
Change committed as 901e96df6916e6f8ba95a4ea85a2ceac31e7d633

Powered by Google App Engine
This is Rietveld 408576698