play fullscreen video in immersive mode

play fullscreen video in immersive mode

For Kitkat, we can play video in immersive mode without the navigation bar.
Maybe we should do the same for other elements?

BUG=378412
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274080

[qinmin, 2014-05-30 00:27:32]

PTAL

[Ted C, 2014-05-30 00:31:37]

https://codereview.chromium.org/303263004/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/ActivityContentVideoViewClient.java
(left):

https://codereview.chromium.org/303263004/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/ActivityContentVideoViewClient.java:27:
mActivity.getWindow().setFlags(
do you want to do this for pre-kitkat still?  same for the clearing flags below.

[qinmin, 2014-05-30 00:46:57]

https://codereview.chromium.org/303263004/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/ActivityContentVideoViewClient.java
(left):

https://codereview.chromium.org/303263004/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/ActivityContentVideoViewClient.java:27:
mActivity.getWindow().setFlags(
Good catch, shouldn't remove these for pre-kitkat devices. Reverted the changes.

On 2014/05/30 00:31:37, Ted C wrote:
> do you want to do this for pre-kitkat still?  same for the clearing flags
below.

[Ted C, 2014-05-30 20:56:08]

https://codereview.chromium.org/303263004/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/ActivityContentVideoViewClient.java
(right):

https://codereview.chromium.org/303263004/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/ActivityContentVideoViewClient.java:30:
WindowManager.LayoutParams.FLAG_FULLSCREEN);
should you only be doing this pre-kitkat?

Just wondering if this and the clearFlags should move into the if block in
setSystemUiVisibility below.

[qinmin, 2014-05-30 22:17:52]

https://codereview.chromium.org/303263004/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/ActivityContentVideoViewClient.java
(right):

https://codereview.chromium.org/303263004/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/ActivityContentVideoViewClient.java:30:
WindowManager.LayoutParams.FLAG_FULLSCREEN);
whether calling setFlag() or not should have no impact post-kitkat. So I will
just leave the statement for both scenarios to simplify the logic.
Moved the code into setSysmtemUiVisibility().

On 2014/05/30 20:56:08, Ted C wrote:
> should you only be doing this pre-kitkat?
> 
> Just wondering if this and the clearFlags should move into the if block in
> setSystemUiVisibility below.

[Ted C, 2014-05-30 22:46:11]

lgtm

[qinmin, 2014-05-31 01:28:16]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2014-05-31 01:29:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/qinmin@chromium.org/303263004/40001

[commit-bot: I haz the power, 2014-05-31 22:44:31]

Change committed as 274080