Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1351)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 303263002: sync: move SharedChangeProcessor to components/ (Closed)

Created:
6 years, 6 months ago by tim (not reviewing)
Modified:
6 years, 6 months ago
Reviewers:
maniscalco
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

sync: move SharedChangeProcessor to components/ Main thing that needed work here was the unittest. BUG=339726 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273960

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -654 lines) Patch
M chrome/browser/sync/glue/non_ui_data_type_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/non_ui_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/sync/glue/shared_change_processor.h View 1 chunk +0 lines, -144 lines 0 comments Download
D chrome/browser/sync/glue/shared_change_processor.cc View 1 chunk +0 lines, -211 lines 0 comments Download
D chrome/browser/sync/glue/shared_change_processor_ref.h View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/sync/glue/shared_change_processor_ref.cc View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/sync/glue/shared_change_processor_unittest.cc View 1 chunk +0 lines, -145 lines 0 comments Download
M chrome/browser/sync/glue/ui_data_type_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/ui_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync_driver.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
A + components/sync_driver/shared_change_processor.h View 4 chunks +4 lines, -6 lines 0 comments Download
A + components/sync_driver/shared_change_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sync_driver/shared_change_processor_ref.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/sync_driver/shared_change_processor_ref.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sync_driver/shared_change_processor_unittest.cc View 1 6 chunks +39 lines, -40 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tim (not reviewing)
6 years, 6 months ago (2014-05-29 19:08:15 UTC) #1
maniscalco
lgtm with one nit https://codereview.chromium.org/303263002/diff/40001/components/sync_driver/shared_change_processor_unittest.cc File components/sync_driver/shared_change_processor_unittest.cc (right): https://codereview.chromium.org/303263002/diff/40001/components/sync_driver/shared_change_processor_unittest.cc#newcode47 components/sync_driver/shared_change_processor_unittest.cc:47: syncer::AttachmentService::Delegate* delegate) { OVERRIDE?
6 years, 6 months ago (2014-05-29 23:04:43 UTC) #2
tim (not reviewing)
The CQ bit was checked by tim@chromium.org
6 years, 6 months ago (2014-05-30 17:39:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/303263002/60001
6 years, 6 months ago (2014-05-30 17:41:29 UTC) #4
tim (not reviewing)
https://codereview.chromium.org/303263002/diff/40001/components/sync_driver/shared_change_processor_unittest.cc File components/sync_driver/shared_change_processor_unittest.cc (right): https://codereview.chromium.org/303263002/diff/40001/components/sync_driver/shared_change_processor_unittest.cc#newcode47 components/sync_driver/shared_change_processor_unittest.cc:47: syncer::AttachmentService::Delegate* delegate) { On 2014/05/29 23:04:43, maniscalco wrote: > ...
6 years, 6 months ago (2014-05-30 17:43:06 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 00:39:44 UTC) #6
Message was sent while issue was closed. 
Change committed as 273960

Powered by Google App Engine
This is Rietveld 408576698