Issue 303253003: QUIC - persist server config in stable and beta channels.

Issue 303253003: QUIC - persist server config in stable and beta channels. (Closed)

Created:
6 years, 6 months ago by ramant (doing other things)

Modified:
6 years, 6 months ago

Reviewers:
Lei Zhang, jar (doing other things), sky

CC:
chromium-reviews, Ryan Hamilton, rvargas (doing something else), wtc, Nico, Lei Zhang

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

QUIC - persist server config in stable and beta channels. BUG=377408 R=jar@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274112

Patch Set 2 : removed chrome/common/chrome_version_info.h include #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -9 lines)			Patch
	M	chrome/browser/io_thread.cc	View	1	2 chunks	+1 line, -9 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

Hi Jim, Deleted the code that disabled persisting of QUIC server config to disk cache ...

6 years, 6 months ago (2014-05-29 19:07:03 UTC) #2

ramant (doing other things)

On 2014/05/31 02:37:32, jar wrote: > LGTM sky@, thakis@ and thestig@, Would appreciate if I ...

6 years, 6 months ago (2014-05-31 20:33:52 UTC) #4

Lei Zhang

lgtm https://codereview.chromium.org/303253003/diff/1/chrome/browser/io_thread.cc File chrome/browser/io_thread.cc (right): https://codereview.chromium.org/303253003/diff/1/chrome/browser/io_thread.cc#newcode42 chrome/browser/io_thread.cc:42: #include "chrome/common/chrome_version_info.h" you can so remove this #include

6 years, 6 months ago (2014-05-31 22:05:54 UTC) #5

ramant (doing other things)

Thanks Lei for the comments and review. https://codereview.chromium.org/303253003/diff/1/chrome/browser/io_thread.cc File chrome/browser/io_thread.cc (right): https://codereview.chromium.org/303253003/diff/1/chrome/browser/io_thread.cc#newcode42 chrome/browser/io_thread.cc:42: #include "chrome/common/chrome_version_info.h" ...

6 years, 6 months ago (2014-06-01 04:50:11 UTC) #6

ramant (doing other things)

The CQ bit was checked by rtenneti@chromium.org

6 years, 6 months ago (2014-06-01 04:50:20 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/303253003/20001

6 years, 6 months ago (2014-06-01 04:50:32 UTC) #8

Message was sent while issue was closed.

Change committed as 274112

Expand Messages | Collapse Messages