Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 303233009: Enable some JsToCppTests. (Closed)

Created:
6 years, 6 months ago by yzshen1
Modified:
6 years, 6 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Enable some JsToCppTests. BUG=366797 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274126

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M mojo/apps/js/test/js_to_cpp_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
yzshen1
Hi, Tom. Please take a look. Thanks!
6 years, 6 months ago (2014-05-31 05:26:59 UTC) #1
Tom Sepez
Code itself LGtM. Presumably the try failures are because LKGR hasn't rolled past your pacth ...
6 years, 6 months ago (2014-05-31 16:37:43 UTC) #2
yzshen1
On 2014/05/31 16:37:43, Tom Sepez wrote: > Code itself LGtM. Presumably the try failures are ...
6 years, 6 months ago (2014-05-31 23:28:47 UTC) #3
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 6 months ago (2014-05-31 23:28:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/303233009/1
6 years, 6 months ago (2014-05-31 23:29:06 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium ...
6 years, 6 months ago (2014-06-01 00:42:52 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-01 00:44:46 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/19683)
6 years, 6 months ago (2014-06-01 00:44:47 UTC) #8
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 6 months ago (2014-06-01 15:01:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/303233009/1
6 years, 6 months ago (2014-06-01 15:01:14 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-01 16:17:40 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-01 17:18:17 UTC) #12
Message was sent while issue was closed.
Change committed as 274126

Powered by Google App Engine
This is Rietveld 408576698