| Index: content/browser/site_per_process_browsertest.cc
|
| diff --git a/content/browser/site_per_process_browsertest.cc b/content/browser/site_per_process_browsertest.cc
|
| index cca1df07c00f07aec94356c46682eb2f9e412746..8dd9535e6b71eb5483423120aa5266a6f31173b1 100644
|
| --- a/content/browser/site_per_process_browsertest.cc
|
| +++ b/content/browser/site_per_process_browsertest.cc
|
| @@ -468,15 +468,12 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest,
|
| test_server()->GetURL("files/frame_tree/top.html"));
|
|
|
| WebContentsImpl* wc = static_cast<WebContentsImpl*>(shell()->web_contents());
|
| - RenderViewHostImpl* rvh = static_cast<RenderViewHostImpl*>(
|
| - wc->GetRenderViewHost());
|
| FrameTreeNode* root = wc->GetFrameTree()->root();
|
|
|
| // Check that the root node is properly created with the frame id of the
|
| // initial navigation.
|
| ASSERT_EQ(3UL, root->child_count());
|
| EXPECT_EQ(std::string(), root->frame_name());
|
| - EXPECT_EQ(rvh->main_frame_id(), root->frame_id());
|
|
|
| ASSERT_EQ(2UL, root->child_at(0)->child_count());
|
| EXPECT_STREQ("1-1-name", root->child_at(0)->frame_name().c_str());
|
| @@ -495,7 +492,6 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest,
|
| root = wc->GetFrameTree()->root();
|
| EXPECT_EQ(0UL, root->child_count());
|
| EXPECT_EQ(std::string(), root->frame_name());
|
| - EXPECT_EQ(rvh->main_frame_id(), root->frame_id());
|
| }
|
|
|
| // Test that we can navigate away if the previous renderer doesn't clean up its
|
| @@ -514,20 +510,22 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest, FrameTreeAfterCrash) {
|
|
|
| // The frame tree should be cleared, and the frame ID should be reset.
|
| WebContentsImpl* wc = static_cast<WebContentsImpl*>(shell()->web_contents());
|
| - RenderViewHostImpl* rvh = static_cast<RenderViewHostImpl*>(
|
| - wc->GetRenderViewHost());
|
| + //RenderViewHostImpl* rvh = static_cast<RenderViewHostImpl*>(
|
| + // wc->GetRenderViewHost());
|
| FrameTreeNode* root = wc->GetFrameTree()->root();
|
| EXPECT_EQ(0UL, root->child_count());
|
| - EXPECT_EQ(FrameTreeNode::kInvalidFrameId, root->frame_id());
|
| - EXPECT_EQ(rvh->main_frame_id(), root->frame_id());
|
| + // TODO(creis): We shouldn't be using frame_id here.
|
| + /*EXPECT_EQ(FrameTreeNode::kInvalidFrameId, root->frame_id());
|
| + EXPECT_EQ(rvh->main_frame_id(), root->frame_id()); */
|
|
|
| // Navigate to a new URL.
|
| NavigateToURL(shell(), test_server()->GetURL("files/title1.html"));
|
|
|
| // The frame ID should now be set.
|
| EXPECT_EQ(0UL, root->child_count());
|
| - EXPECT_NE(FrameTreeNode::kInvalidFrameId, root->frame_id());
|
| - EXPECT_EQ(rvh->main_frame_id(), root->frame_id());
|
| + // TODO(creis): We shouldn't be using frame_id here.
|
| + /*EXPECT_NE(FrameTreeNode::kInvalidFrameId, root->frame_id());
|
| + EXPECT_EQ(rvh->main_frame_id(), root->frame_id()); */
|
| }
|
|
|
| // Test that we can navigate away if the previous renderer doesn't clean up its
|
| @@ -562,7 +560,8 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest, NavigateWithLeftoverFrames) {
|
|
|
| // The frame tree should now be cleared, and the frame ID should be valid.
|
| EXPECT_EQ(0UL, root->child_count());
|
| - EXPECT_NE(FrameTreeNode::kInvalidFrameId, root->frame_id());
|
| + // TODO(creis): We shouldn't be using frame_id here.
|
| + //EXPECT_NE(FrameTreeNode::kInvalidFrameId, root->frame_id());
|
| }
|
|
|
| // Tests that the |should_replace_current_entry| flag persists correctly across
|
|
|