Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: content/browser/frame_host/frame_tree_node.h

Issue 30323002: [DRAFT] Create RenderFrameHostManager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Misc fixes Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/frame_tree.cc ('k') | content/browser/frame_host/frame_tree_node.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/frame_tree_node.h
diff --git a/content/browser/frame_host/frame_tree_node.h b/content/browser/frame_host/frame_tree_node.h
index e7b0800319e1332cefbf88c2bf42905c6787a38a..6a5a86e153dde4725ba5a4ca2899f89adb8acf61 100644
--- a/content/browser/frame_host/frame_tree_node.h
+++ b/content/browser/frame_host/frame_tree_node.h
@@ -28,15 +28,12 @@ class RenderFrameHostImpl;
// are frame-specific (as opposed to page-specific).
class CONTENT_EXPORT FrameTreeNode {
public:
- static const int64 kInvalidFrameId;
-
FrameTreeNode(FrameTree* frame_tree,
Navigator* navigator,
RenderFrameHostDelegate* render_frame_delegate,
RenderViewHostDelegate* render_view_delegate,
RenderWidgetHostDelegate* render_widget_delegate,
RenderFrameHostManager::Delegate* manager_delegate,
- int64 frame_id,
const std::string& name);
~FrameTreeNode();
@@ -62,20 +59,13 @@ class CONTENT_EXPORT FrameTreeNode {
return &render_manager_;
}
+ // This is the browser-wide unique ID for the FrameTreeNode. If you have a
+ // renderer-specific frame ID, you can look up the corresponding FrameTreeNode
+ // ID using RenderViewHostImpl::GetFrameTreeNodeID(frame_id).
int64 frame_tree_node_id() const {
return frame_tree_node_id_;
}
- // DO NOT USE. Only used by FrameTree until we replace renderer-specific
- // frame IDs with RenderFrameHost routing IDs.
- void set_frame_id(int64 frame_id) {
- DCHECK_EQ(frame_id_, kInvalidFrameId);
- frame_id_ = frame_id;
- }
- int64 frame_id() const {
- return frame_id_;
- }
-
const std::string& frame_name() const {
return frame_name_;
}
@@ -113,7 +103,7 @@ class CONTENT_EXPORT FrameTreeNode {
// Manages creation and swapping of RenderFrameHosts for this frame. This
// must be declared before |children_| so that it gets deleted after them.
- // That's currently necessary so that RenderFrameHostImpl's destructor can
+ // That's currently necessary so that RenderFrameHostImpl's destructor can
// call GetProcess.
RenderFrameHostManager render_manager_;
@@ -121,12 +111,6 @@ class CONTENT_EXPORT FrameTreeNode {
// even if the frame does a cross-process navigation.
const int64 frame_tree_node_id_;
- // The renderer-specific identifier for the frame in the page.
- // TODO(creis): Remove this in favor of the RenderFrameHost's routing ID once
- // we create FrameTreeNodes for all frames (even without a flag), since this
- // value can change after cross-process navigations.
- int64 frame_id_;
-
// The assigned name of the frame. This name can be empty, unlike the unique
// name generated internally in the DOM tree.
std::string frame_name_;
« no previous file with comments | « content/browser/frame_host/frame_tree.cc ('k') | content/browser/frame_host/frame_tree_node.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698