[DRAFT] Create RenderFrameHostManager.

content/browser/renderer_host/render_view_host_impl.cc

Index: content/browser/renderer_host/render_view_host_impl.cc
diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc
index 65b38234e0472450a62b075b73339f918345d71f..1c65e2c580331dfc7850b185350a1df989382694 100644
--- a/content/browser/renderer_host/render_view_host_impl.cc
+++ b/content/browser/renderer_host/render_view_host_impl.cc
@@ -173,7 +173,7 @@ RenderViewHostImpl::RenderViewHostImpl(
       has_accessed_initial_document_(false),
       is_swapped_out_(swapped_out),
       is_subframe_(false),
-      main_frame_id_(-1),
+      main_frame_routing_id_(main_frame_routing_id),
       run_modal_reply_msg_(NULL),
       run_modal_opener_id_(MSG_ROUTING_NONE),
       is_waiting_for_beforeunload_ack_(false),
@@ -186,13 +186,6 @@ RenderViewHostImpl::RenderViewHostImpl(
   DCHECK(instance_.get());
   CHECK(delegate_);  // http://crbug.com/82827
 
-  if (main_frame_routing_id == MSG_ROUTING_NONE)
-    main_frame_routing_id = GetProcess()->GetNextRoutingID();
-
-  main_render_frame_host_.reset(
-      new RenderFrameHostImpl(this, delegate_->GetFrameTree(),
-                              main_frame_routing_id, is_swapped_out_));
-
   GetProcess()->EnableSendQueue();
 
   if (!swapped_out)
@@ -205,6 +198,9 @@ RenderViewHostImpl::RenderViewHostImpl(
                    base::Unretained(ResourceDispatcherHostImpl::Get()),
                    GetProcess()->GetID(), GetRoutingID()));
   }
+  LOG(INFO) << "NEW RVH: process " << GetProcess()->GetID() <<
+      ", route " << GetRoutingID() << ", SID " <<
+      instance_->GetId() << ", site " << instance_->GetSiteURL();
 
 #if defined(OS_ANDROID)
   media_player_manager_.reset(BrowserMediaPlayerManager::Create(this));
@@ -212,6 +208,8 @@ RenderViewHostImpl::RenderViewHostImpl(
 }
 
 RenderViewHostImpl::~RenderViewHostImpl() {
+  LOG(INFO) << "DELETE RVH: process " << GetProcess()->GetID() <<
+      ", route " << GetRoutingID() << ", SID " << instance_->GetId();
   if (ResourceDispatcherHostImpl::Get()) {
     BrowserThread::PostTask(
         BrowserThread::IO, FROM_HERE,
@@ -240,6 +238,52 @@ SiteInstance* RenderViewHostImpl::GetSiteInstance() const {
   return instance_.get();
 }
 
+void RenderViewHostImpl::RegisterRenderFrameHost(
+    RenderFrameHostImpl* render_frame_host) {
+  LOG(INFO) << "RVH incrementing refcount with instance " <<
+      instance_->GetId() << " for " << instance_->GetSiteURL();
+  CHECK(rfh_list_.find(render_frame_host) == rfh_list_.end());
+  rfh_list_.insert(render_frame_host);
+}
+
+void RenderViewHostImpl::UnregisterRenderFrameHost(
+    RenderFrameHostImpl* render_frame_host) {
+  LOG(INFO) << "RVH decrementing refcount with instance " <<
+      instance_->GetId() << " for " << instance_->GetSiteURL();
+  CHECK(rfh_list_.find(render_frame_host) != rfh_list_.end());
+  rfh_list_.erase(render_frame_host);
+  if (rfh_list_.size() == 0)
+    Shutdown();
+}
+
+void RenderViewHostImpl::RegisterFrameID(int64 frame_id,
+                                         int64 frame_tree_node_id) {
+  frame_id_map_[frame_id] = frame_tree_node_id;
+}
+
+void RenderViewHostImpl::UnregisterFrameID(int64 frame_id) {
+  CHECK(HasFrameID(frame_id));
+  frame_id_map_.erase(frame_id);
+}
+
+bool RenderViewHostImpl::HasFrameID(int64 frame_id) const {
+  return frame_id_map_.find(frame_id) != frame_id_map_.end();
+}
+
+int64 RenderViewHostImpl::GetFrameTreeNodeID(int64 frame_id) {
+  return frame_id_map_[frame_id];
+}
+
+int64 RenderViewHostImpl::GetFrameIDForTesting(int64 frame_tree_node_id) const {
+  for (FrameIDMap::const_iterator iter = frame_id_map_.begin();
+       iter != frame_id_map_.end();
+       iter++) {
+    if (iter->second == frame_tree_node_id)
+      return iter->first;
+  }
+  return -1;
+}
+
 bool RenderViewHostImpl::CreateRenderView(
     const string16& frame_name,
     int opener_route_id,
@@ -272,7 +316,7 @@ bool RenderViewHostImpl::CreateRenderView(
       delegate_->GetRendererPrefs(GetProcess()->GetBrowserContext());
   params.web_preferences = delegate_->GetWebkitPrefs();
   params.view_id = GetRoutingID();
-  params.main_frame_routing_id = main_render_frame_host()->routing_id();
+  params.main_frame_routing_id = main_frame_routing_id_;
   params.surface_id = surface_id();
   params.session_storage_namespace_id =
       delegate_->GetSessionStorageNamespace(instance_)->id();
@@ -670,8 +714,18 @@ void RenderViewHostImpl::OnCrossSiteResponse(
     const Referrer& referrer,
     PageTransition page_transition,
     int64 frame_id) {
-  RenderViewHostDelegate::RendererManagement* manager =
-      delegate_->GetRendererManagementDelegate();
+  FrameTreeNode* node = NULL;
+  if (frame_id != -1) {
+    CHECK(HasFrameID(frame_id));
+    int64 frame_tree_node_id = GetFrameTreeNodeID(frame_id);
+    node = delegate_->GetFrameTree()->FindByID(frame_tree_node_id);
+  }
+
+  // TODO(creis): We should always be able to get the RFHM for a frame_id,
+  // but today the frame_id is -1 for the main frame.
+  RenderViewHostDelegate::RendererManagement* manager = node ?
+      node->render_manager() : delegate_->GetRenderManager();
+  CHECK(manager);
   if (manager) {
     manager->OnCrossSiteResponse(this, global_request_id, is_transfer,
                                  transfer_url_chain, referrer, page_transition,
@@ -1272,7 +1326,8 @@ bool RenderViewHostImpl::OnMessageReceived(const IPC::Message& msg) {
 
 void RenderViewHostImpl::Init() {
   RenderWidgetHostImpl::Init();
-  main_render_frame_host()->Init();
+  // TODO(creis): The caller of this should call Init on the RFH as well.
+  //main_render_frame_host()->Init();
 }
 
 void RenderViewHostImpl::Shutdown() {
@@ -1382,7 +1437,7 @@ void RenderViewHostImpl::OnRenderProcessGone(int status, int exit_code) {
       static_cast<base::TerminationStatus>(status);
 
   // Reset state.
-  main_frame_id_ = -1;
+  frame_id_map_.clear();
 
   // Our base class RenderWidgetHost needs to reset some stuff.
   RendererExited(render_view_termination_status_, exit_code);
@@ -1456,13 +1511,16 @@ void RenderViewHostImpl::OnNavigate(const IPC::Message& msg) {
   // Cache the main frame id, so we can use it for creating the frame tree
   // root node when needed.
   if (PageTransitionIsMainFrame(validated_params.transition)) {
-    if (main_frame_id_ == -1) {
-      main_frame_id_ = validated_params.frame_id;
+    int frame_tree_node_id =
+        delegate_->GetFrameTree()->root()->frame_tree_node_id();
+    if (!HasFrameID(validated_params.frame_id)) {
+      RegisterFrameID(validated_params.frame_id, frame_tree_node_id);
     } else {
       // TODO(nasko): We plan to remove the usage of frame_id in navigation
       // and move to routing ids. This is in place to ensure that a
       // renderer is not misbehaving and sending us incorrect data.
-      DCHECK_EQ(main_frame_id_, validated_params.frame_id);
+      DCHECK_EQ(frame_tree_node_id,
+                GetFrameTreeNodeID(validated_params.frame_id));
     }
   }
   RenderProcessHost* process = GetProcess();
@@ -1810,7 +1868,7 @@ void RenderViewHostImpl::OnShouldCloseACK(
   is_waiting_for_beforeunload_ack_ = false;
 
   RenderViewHostDelegate::RendererManagement* management_delegate =
-      delegate_->GetRendererManagementDelegate();
+      delegate_->GetRenderManager();
   if (management_delegate) {
     base::TimeTicks before_unload_end_time;
     if (!send_should_close_start_time_.is_null() &&
@@ -2274,13 +2332,4 @@ bool RenderViewHostImpl::CanAccessFilesOfPageState(
   return true;
 }
 
-void RenderViewHostImpl::AttachToFrameTree() {
-  FrameTree* frame_tree = delegate_->GetFrameTree();
-
-  frame_tree->SwapMainFrame(main_render_frame_host_.get());
-  if (main_frame_id() != FrameTreeNode::kInvalidFrameId) {
-    frame_tree->OnFirstNavigationAfterSwap(main_frame_id());
-  }
-}
-
 }  // namespace content