| Index: content/browser/frame_host/render_view_host_manager.cc
|
| diff --git a/content/browser/frame_host/render_view_host_manager.cc b/content/browser/frame_host/render_view_host_manager.cc
|
| index a8473cd19969eb4c3abaf0180bae9767008847bd..10390c9c705620c47a8bafa8d2f661654b714939 100644
|
| --- a/content/browser/frame_host/render_view_host_manager.cc
|
| +++ b/content/browser/frame_host/render_view_host_manager.cc
|
| @@ -54,33 +54,35 @@ RenderViewHostManager::PendingNavigationParams::PendingNavigationParams(
|
| RenderViewHostManager::PendingNavigationParams::~PendingNavigationParams() {}
|
|
|
| RenderViewHostManager::RenderViewHostManager(
|
| + FrameTreeNode* frame_tree_node,
|
| RenderViewHostDelegate* render_view_delegate,
|
| RenderWidgetHostDelegate* render_widget_delegate,
|
| Delegate* delegate)
|
| - : delegate_(delegate),
|
| + : frame_tree_node_(frame_tree_node),
|
| + delegate_(delegate),
|
| cross_navigation_pending_(false),
|
| render_view_delegate_(render_view_delegate),
|
| render_widget_delegate_(render_widget_delegate),
|
| - render_view_host_(NULL),
|
| - pending_render_view_host_(NULL),
|
| + render_frame_host_(NULL),
|
| + pending_render_frame_host_(NULL),
|
| interstitial_page_(NULL) {
|
| }
|
|
|
| RenderViewHostManager::~RenderViewHostManager() {
|
| - if (pending_render_view_host_)
|
| + if (pending_render_frame_host_)
|
| CancelPending();
|
|
|
| - // We should always have a main RenderViewHost except in some tests.
|
| - RenderViewHostImpl* render_view_host = render_view_host_;
|
| - render_view_host_ = NULL;
|
| - if (render_view_host)
|
| - render_view_host->Shutdown();
|
| + // We should always have a current RenderFrameHost except in some tests.
|
| + RenderFrameHostImpl* render_frame_host = render_frame_host_;
|
| + render_frame_host_ = NULL;
|
| + if (render_frame_host)
|
| + delete render_frame_host;
|
|
|
| - // Shut down any swapped out RenderViewHosts.
|
| - for (RenderViewHostMap::iterator iter = swapped_out_hosts_.begin();
|
| + // Delete any swapped out RenderFrameHosts.
|
| + for (RenderFrameHostMap::iterator iter = swapped_out_hosts_.begin();
|
| iter != swapped_out_hosts_.end();
|
| ++iter) {
|
| - iter->second->Shutdown();
|
| + delete iter->second;
|
| }
|
| }
|
|
|
| @@ -89,16 +91,25 @@ void RenderViewHostManager::Init(BrowserContext* browser_context,
|
| int routing_id,
|
| int main_frame_routing_id) {
|
| // Create a RenderViewHost, once we have an instance. It is important to
|
| - // immediately give this SiteInstance to a RenderViewHost so that it is
|
| - // ref counted.
|
| + // immediately give this SiteInstance to a RenderViewHost so that the
|
| + // SiteInstance is ref counted.
|
| if (!site_instance)
|
| site_instance = SiteInstance::Create(browser_context);
|
| - render_view_host_ = static_cast<RenderViewHostImpl*>(
|
| - RenderViewHostFactory::Create(
|
| - site_instance, render_view_delegate_, render_widget_delegate_,
|
| - routing_id, main_frame_routing_id, false,
|
| - delegate_->IsHidden()));
|
| - render_view_host_->AttachToFrameTree();
|
| +
|
| + if (main_frame_routing_id == MSG_ROUTING_NONE)
|
| + main_frame_routing_id = site_instance->GetProcess()->GetNextRoutingID();
|
| +
|
| + // TODO(creis): Abstract this out and share with CreateRenderFrame.
|
| + FrameTree* frame_tree = render_view_delegate_->GetFrameTree();
|
| + RenderViewHostImpl* render_view_host =
|
| + frame_tree->GetRenderViewHostForNewFrame(site_instance, routing_id,
|
| + main_frame_routing_id,
|
| + false, false);
|
| + render_frame_host_ = new RenderFrameHostImpl(render_view_host,
|
| + frame_tree,
|
| + frame_tree_node_,
|
| + main_frame_routing_id,
|
| + false);
|
|
|
| // Keep track of renderer processes as they start to shut down or are
|
| // crashed/killed.
|
| @@ -109,19 +120,25 @@ void RenderViewHostManager::Init(BrowserContext* browser_context,
|
| }
|
|
|
| RenderViewHostImpl* RenderViewHostManager::current_host() const {
|
| - return render_view_host_;
|
| + return render_frame_host_->render_view_host();
|
| }
|
|
|
| RenderViewHostImpl* RenderViewHostManager::pending_render_view_host() const {
|
| - return pending_render_view_host_;
|
| + if (!pending_render_frame_host_)
|
| + return NULL;
|
| + return pending_render_frame_host_->render_view_host();
|
| +}
|
| +
|
| +RenderFrameHostImpl* RenderViewHostManager::pending_render_frame_host() const {
|
| + return pending_render_frame_host_;
|
| }
|
|
|
| RenderWidgetHostView* RenderViewHostManager::GetRenderWidgetHostView() const {
|
| if (interstitial_page_)
|
| return interstitial_page_->GetView();
|
| - if (!render_view_host_)
|
| + if (!render_frame_host_)
|
| return NULL;
|
| - return render_view_host_->GetView();
|
| + return render_frame_host_->render_view_host()->GetView();
|
| }
|
|
|
| void RenderViewHostManager::SetPendingWebUI(const NavigationEntryImpl& entry) {
|
| @@ -144,107 +161,120 @@ void RenderViewHostManager::SetPendingWebUI(const NavigationEntryImpl& entry) {
|
| RenderViewHostImpl* RenderViewHostManager::Navigate(
|
| const NavigationEntryImpl& entry) {
|
| TRACE_EVENT0("browser", "RenderViewHostManager:Navigate");
|
| - // Create a pending RenderViewHost. It will give us the one we should use
|
| - RenderViewHostImpl* dest_render_view_host =
|
| - static_cast<RenderViewHostImpl*>(UpdateRendererStateForNavigate(entry));
|
| - if (!dest_render_view_host)
|
| - return NULL; // We weren't able to create a pending render view host.
|
| -
|
| - // If the current render_view_host_ isn't live, we should create it so
|
| - // that we don't show a sad tab while the dest_render_view_host fetches
|
| + // Create a pending RenderFrameHost to use for the navigation.
|
| + RenderFrameHostImpl* dest_render_frame_host =
|
| + UpdateRendererStateForNavigate(entry);
|
| + if (!dest_render_frame_host)
|
| + return NULL; // We weren't able to create a pending render frame host.
|
| +
|
| + // If the current render_frame_host_ isn't live, we should create it so
|
| + // that we don't show a sad tab while the dest_render_frame_host fetches
|
| // its first page. (Bug 1145340)
|
| - if (dest_render_view_host != render_view_host_ &&
|
| - !render_view_host_->IsRenderViewLive()) {
|
| + if (dest_render_frame_host != render_frame_host_ &&
|
| + !render_frame_host_->render_view_host()->IsRenderViewLive()) {
|
| // Note: we don't call InitRenderView here because we are navigating away
|
| // soon anyway, and we don't have the NavigationEntry for this host.
|
| - delegate_->CreateRenderViewForRenderManager(render_view_host_,
|
| - MSG_ROUTING_NONE);
|
| + delegate_->CreateRenderViewForRenderManager(
|
| + render_frame_host_->render_view_host(), MSG_ROUTING_NONE);
|
| }
|
|
|
| // If the renderer crashed, then try to create a new one to satisfy this
|
| // navigation request.
|
| - if (!dest_render_view_host->IsRenderViewLive()) {
|
| + if (!dest_render_frame_host->render_view_host()->IsRenderViewLive()) {
|
| // Recreate the opener chain.
|
| int opener_route_id = delegate_->CreateOpenerRenderViewsForRenderManager(
|
| - dest_render_view_host->GetSiteInstance());
|
| - if (!InitRenderView(dest_render_view_host, opener_route_id))
|
| + dest_render_frame_host->render_view_host()->GetSiteInstance());
|
| + if (!InitRenderView(dest_render_frame_host->render_view_host(),
|
| + opener_route_id))
|
| return NULL;
|
|
|
| // Now that we've created a new renderer, be sure to hide it if it isn't
|
| // our primary one. Otherwise, we might crash if we try to call Show()
|
| // on it later.
|
| - if (dest_render_view_host != render_view_host_ &&
|
| - dest_render_view_host->GetView()) {
|
| - dest_render_view_host->GetView()->Hide();
|
| + if (dest_render_frame_host != render_frame_host_ &&
|
| + dest_render_frame_host->render_view_host()->GetView()) {
|
| + dest_render_frame_host->render_view_host()->GetView()->Hide();
|
| } else {
|
| // This is our primary renderer, notify here as we won't be calling
|
| // CommitPending (which does the notify).
|
| - delegate_->NotifySwappedFromRenderManager(NULL, render_view_host_);
|
| + // TODO(creis): only do this for top-level frames, when the RVH changes.
|
| + delegate_->NotifySwappedFromRenderManager(
|
| + NULL, render_frame_host_->render_view_host());
|
| }
|
| }
|
|
|
| - return dest_render_view_host;
|
| + // TODO(creis): Return the RFH instead, once we can navigate RFHs.
|
| + return dest_render_frame_host->render_view_host();
|
| }
|
|
|
| void RenderViewHostManager::Stop() {
|
| - render_view_host_->Stop();
|
| + render_frame_host_->render_view_host()->Stop();
|
|
|
| // If we are cross-navigating, we should stop the pending renderers. This
|
| // will lead to a DidFailProvisionalLoad, which will properly destroy them.
|
| if (cross_navigation_pending_) {
|
| - pending_render_view_host_->Send(
|
| - new ViewMsg_Stop(pending_render_view_host_->GetRoutingID()));
|
| + pending_render_frame_host_->render_view_host()->Send(new ViewMsg_Stop(
|
| + pending_render_frame_host_->render_view_host()->GetRoutingID()));
|
| }
|
| }
|
|
|
| void RenderViewHostManager::SetIsLoading(bool is_loading) {
|
| - render_view_host_->SetIsLoading(is_loading);
|
| - if (pending_render_view_host_)
|
| - pending_render_view_host_->SetIsLoading(is_loading);
|
| + render_frame_host_->render_view_host()->SetIsLoading(is_loading);
|
| + if (pending_render_frame_host_)
|
| + pending_render_frame_host_->render_view_host()->SetIsLoading(is_loading);
|
| }
|
|
|
| bool RenderViewHostManager::ShouldCloseTabOnUnresponsiveRenderer() {
|
| if (!cross_navigation_pending_)
|
| return true;
|
|
|
| - // We should always have a pending RVH when there's a cross-process navigation
|
| + // We should always have a pending RFH when there's a cross-process navigation
|
| // in progress. Sanity check this for http://crbug.com/276333.
|
| - CHECK(pending_render_view_host_);
|
| + CHECK(pending_render_frame_host_);
|
|
|
| // If the tab becomes unresponsive during {before}unload while doing a
|
| // cross-site navigation, proceed with the navigation. (This assumes that
|
| - // the pending RenderViewHost is still responsive.)
|
| - if (render_view_host_->is_waiting_for_unload_ack()) {
|
| + // the pending RenderFrameHost is still responsive.)
|
| + if (render_frame_host_->render_view_host()->is_waiting_for_unload_ack()) {
|
| // The request has been started and paused while we're waiting for the
|
| // unload handler to finish. We'll pretend that it did. The pending
|
| // renderer will then be swapped in as part of the usual DidNavigate logic.
|
| // (If the unload handler later finishes, this call will be ignored because
|
| // the pending_nav_params_ state will already be cleaned up.)
|
| current_host()->OnSwappedOut(true);
|
| - } else if (render_view_host_->is_waiting_for_beforeunload_ack()) {
|
| + } else if (render_frame_host_->render_view_host()->
|
| + is_waiting_for_beforeunload_ack()) {
|
| // Haven't gotten around to starting the request, because we're still
|
| // waiting for the beforeunload handler to finish. We'll pretend that it
|
| // did finish, to let the navigation proceed. Note that there's a danger
|
| // that the beforeunload handler will later finish and possibly return
|
| // false (meaning the navigation should not proceed), but we'll ignore it
|
| // in this case because it took too long.
|
| - if (pending_render_view_host_->are_navigations_suspended())
|
| - pending_render_view_host_->SetNavigationsSuspended(
|
| + if (pending_render_frame_host_->render_view_host()->
|
| + are_navigations_suspended()) {
|
| + pending_render_frame_host_->render_view_host()->SetNavigationsSuspended(
|
| false, base::TimeTicks::Now());
|
| + }
|
| }
|
| return false;
|
| }
|
|
|
| +// TODO(creis): Remove this in favor of SwappedOutFrame.
|
| void RenderViewHostManager::SwappedOut(RenderViewHost* render_view_host) {
|
| // Make sure this is from our current RVH, and that we have a pending
|
| // navigation from OnCrossSiteResponse. (There may be no pending navigation
|
| // for data URLs that don't make network requests, for example.) If not,
|
| // just return early and ignore.
|
| - if (render_view_host != render_view_host_ || !pending_nav_params_.get()) {
|
| + if (render_view_host != render_frame_host_->render_view_host() ||
|
| + !pending_nav_params_.get()) {
|
| pending_nav_params_.reset();
|
| return;
|
| }
|
|
|
| + // We should probably sanity check that this is for the correct frame.
|
| + // TODO(creis): Is this frame ID trusted? Which frame is it for?
|
| + //DCHECK_EQ(frame_tree_node_->GetID()?, pending_nav_params_->frame_id);
|
| +
|
| // Now that the unload handler has run, we need to either initiate the
|
| // pending transfer (if there is one) or resume the paused response (if not).
|
| // TODO(creis): The blank swapped out page is visible during this time, but
|
| @@ -260,6 +290,7 @@ void RenderViewHostManager::SwappedOut(RenderViewHost* render_view_host) {
|
| // We don't know whether the original request had |user_action| set to true.
|
| // However, since we force the navigation to be in the current tab, it
|
| // doesn't matter.
|
| + // TODO(creis): Move RequestTransferURL to RenderFrameHost's navigator.
|
| render_view_host->GetDelegate()->RequestTransferURL(
|
| transfer_url,
|
| pending_nav_params_->transfer_url_chain,
|
| @@ -270,23 +301,76 @@ void RenderViewHostManager::SwappedOut(RenderViewHost* render_view_host) {
|
| pending_nav_params_->global_request_id,
|
| false,
|
| true);
|
| - } else if (pending_render_view_host_) {
|
| + } else if (pending_render_frame_host_) {
|
| + RenderProcessHostImpl* pending_process =
|
| + static_cast<RenderProcessHostImpl*>(
|
| + pending_render_frame_host_->GetProcess());
|
| + pending_process->ResumeDeferredNavigation(
|
| + pending_nav_params_->global_request_id);
|
| + }
|
| + pending_nav_params_.reset();
|
| +}
|
| +
|
| +
|
| +void RenderViewHostManager::SwappedOutFrame(
|
| + RenderFrameHostImpl* render_frame_host) {
|
| + // Make sure this is from our current RFH, and that we have a pending
|
| + // navigation from OnCrossSiteResponse. (There may be no pending navigation
|
| + // for data URLs that don't make network requests, for example.) If not,
|
| + // just return early and ignore.
|
| + if (render_frame_host != render_frame_host_ || !pending_nav_params_.get()) {
|
| + pending_nav_params_.reset();
|
| + return;
|
| + }
|
| +
|
| + // We should probably sanity check that this is for the correct frame.
|
| + // TODO(creis): Is this frame ID trusted? Which frame is it for?
|
| + //DCHECK_EQ(frame_tree_node_->GetID()?, pending_nav_params_->frame_id);
|
| +
|
| + // Now that the unload handler has run, we need to either initiate the
|
| + // pending transfer (if there is one) or resume the paused response (if not).
|
| + // TODO(creis): The blank swapped out page is visible during this time, but
|
| + // we can shorten this by delivering the response directly, rather than
|
| + // forcing an identical request to be made.
|
| + if (pending_nav_params_->is_transfer) {
|
| + // Treat the last URL in the chain as the destination and the remainder as
|
| + // the redirect chain.
|
| + CHECK(pending_nav_params_->transfer_url_chain.size());
|
| + GURL transfer_url = pending_nav_params_->transfer_url_chain.back();
|
| + pending_nav_params_->transfer_url_chain.pop_back();
|
| +
|
| + // We don't know whether the original request had |user_action| set to true.
|
| + // However, since we force the navigation to be in the current tab, it
|
| + // doesn't matter.
|
| + // TODO(creis): Move RequestTransferURL to RenderFrameHost's navigator.
|
| + render_frame_host->render_view_host()->GetDelegate()->RequestTransferURL(
|
| + transfer_url,
|
| + pending_nav_params_->transfer_url_chain,
|
| + pending_nav_params_->referrer,
|
| + pending_nav_params_->page_transition,
|
| + CURRENT_TAB,
|
| + pending_nav_params_->frame_id,
|
| + pending_nav_params_->global_request_id,
|
| + false,
|
| + true);
|
| + } else if (pending_render_frame_host_) {
|
| RenderProcessHostImpl* pending_process =
|
| static_cast<RenderProcessHostImpl*>(
|
| - pending_render_view_host_->GetProcess());
|
| + pending_render_frame_host_->GetProcess());
|
| pending_process->ResumeDeferredNavigation(
|
| pending_nav_params_->global_request_id);
|
| }
|
| pending_nav_params_.reset();
|
| }
|
|
|
| +// TODO(creis): Take in a RenderFrameHost.
|
| void RenderViewHostManager::DidNavigateMainFrame(
|
| RenderViewHost* render_view_host) {
|
| if (!cross_navigation_pending_) {
|
| - DCHECK(!pending_render_view_host_);
|
| + DCHECK(!pending_render_frame_host_);
|
|
|
| // We should only hear this from our current renderer.
|
| - DCHECK(render_view_host == render_view_host_);
|
| + DCHECK(render_view_host == render_frame_host_->render_view_host());
|
|
|
| // Even when there is no pending RVH, there may be a pending Web UI.
|
| if (pending_web_ui())
|
| @@ -294,17 +378,18 @@ void RenderViewHostManager::DidNavigateMainFrame(
|
| return;
|
| }
|
|
|
| - if (render_view_host == pending_render_view_host_) {
|
| + if (render_view_host == pending_render_frame_host_->render_view_host()) {
|
| // The pending cross-site navigation completed, so show the renderer.
|
| // If it committed without sending network requests (e.g., data URLs),
|
| - // then we still need to swap out the old RVH first and run its unload
|
| + // then we still need to swap out the old RFH first and run its unload
|
| // handler. OK for that to happen in the background.
|
| - if (pending_render_view_host_->HasPendingCrossSiteRequest())
|
| + if (pending_render_frame_host_->render_view_host()->
|
| + HasPendingCrossSiteRequest())
|
| SwapOutOldPage();
|
|
|
| CommitPending();
|
| cross_navigation_pending_ = false;
|
| - } else if (render_view_host == render_view_host_) {
|
| + } else if (render_view_host == render_frame_host_->render_view_host()) {
|
| // A navigation in the original page has taken place. Cancel the pending
|
| // one.
|
| CancelPending();
|
| @@ -315,14 +400,15 @@ void RenderViewHostManager::DidNavigateMainFrame(
|
| }
|
| }
|
|
|
| +// TODO(creis): Take in RenderFrameHost instead, since frames can have openers.
|
| void RenderViewHostManager::DidDisownOpener(RenderViewHost* render_view_host) {
|
| - // Notify all swapped out hosts, including the pending RVH.
|
| - for (RenderViewHostMap::iterator iter = swapped_out_hosts_.begin();
|
| + // Notify all swapped out hosts, including the pending RFH.
|
| + for (RenderFrameHostMap::iterator iter = swapped_out_hosts_.begin();
|
| iter != swapped_out_hosts_.end();
|
| ++iter) {
|
| - DCHECK_NE(iter->second->GetSiteInstance(),
|
| + DCHECK_NE(iter->second->render_view_host()->GetSiteInstance(),
|
| current_host()->GetSiteInstance());
|
| - iter->second->DisownOpener();
|
| + iter->second->render_view_host()->DisownOpener();
|
| }
|
| }
|
|
|
| @@ -346,7 +432,7 @@ void RenderViewHostManager::RendererProcessClosing(
|
| // swap them back in while the process is exiting. Start by finding them,
|
| // since there could be more than one.
|
| std::list<int> ids_to_remove;
|
| - for (RenderViewHostMap::iterator iter = swapped_out_hosts_.begin();
|
| + for (RenderFrameHostMap::iterator iter = swapped_out_hosts_.begin();
|
| iter != swapped_out_hosts_.end();
|
| ++iter) {
|
| if (iter->second->GetProcess() == render_process_host)
|
| @@ -355,7 +441,7 @@ void RenderViewHostManager::RendererProcessClosing(
|
|
|
| // Now delete them.
|
| while (!ids_to_remove.empty()) {
|
| - swapped_out_hosts_[ids_to_remove.back()]->Shutdown();
|
| + delete swapped_out_hosts_[ids_to_remove.back()];
|
| swapped_out_hosts_.erase(ids_to_remove.back());
|
| ids_to_remove.pop_back();
|
| }
|
| @@ -376,9 +462,11 @@ void RenderViewHostManager::ShouldClosePage(
|
| // might be because the renderer was deemed unresponsive and this call was
|
| // already made by ShouldCloseTabOnUnresponsiveRenderer. In that case, it
|
| // is ok to do nothing here.
|
| - if (pending_render_view_host_ &&
|
| - pending_render_view_host_->are_navigations_suspended()) {
|
| - pending_render_view_host_->SetNavigationsSuspended(false, proceed_time);
|
| + if (pending_render_frame_host_ &&
|
| + pending_render_frame_host_->render_view_host()->
|
| + are_navigations_suspended()) {
|
| + pending_render_frame_host_->render_view_host()->
|
| + SetNavigationsSuspended(false, proceed_time);
|
| }
|
| } else {
|
| // Current page says to cancel.
|
| @@ -392,20 +480,21 @@ void RenderViewHostManager::ShouldClosePage(
|
| &proceed_to_fire_unload);
|
|
|
| if (proceed_to_fire_unload) {
|
| - // If we're about to close the tab and there's a pending RVH, cancel it.
|
| - // Otherwise, if the navigation in the pending RVH completes before the
|
| - // close in the current RVH, we'll lose the tab close.
|
| - if (pending_render_view_host_) {
|
| + // If we're about to close the tab and there's a pending RFH, cancel it.
|
| + // Otherwise, if the navigation in the pending RFH completes before the
|
| + // close in the current RFH, we'll lose the tab close.
|
| + if (pending_render_frame_host_) {
|
| CancelPending();
|
| cross_navigation_pending_ = false;
|
| }
|
|
|
| // This is not a cross-site navigation, the tab is being closed.
|
| - render_view_host_->ClosePage();
|
| + render_frame_host_->render_view_host()->ClosePage();
|
| }
|
| }
|
| }
|
|
|
| +// TODO(creis): Take in a RenderFrameHost from CSRH.
|
| void RenderViewHostManager::OnCrossSiteResponse(
|
| RenderViewHost* pending_render_view_host,
|
| const GlobalRequestID& global_request_id,
|
| @@ -416,9 +505,9 @@ void RenderViewHostManager::OnCrossSiteResponse(
|
| int64 frame_id) {
|
| // This should be called either when the pending RVH is ready to commit or
|
| // when we realize that the current RVH's request requires a transfer.
|
| - DCHECK(
|
| - pending_render_view_host == pending_render_view_host_ ||
|
| - pending_render_view_host == render_view_host_);
|
| + DCHECK(pending_render_view_host == render_frame_host_->render_view_host() ||
|
| + pending_render_view_host ==
|
| + pending_render_frame_host_->render_view_host());
|
|
|
| // TODO(creis): Eventually we will want to check all navigation responses
|
| // here, but currently we pass information for a transfer if
|
| @@ -440,7 +529,7 @@ void RenderViewHostManager::SwapOutOldPage() {
|
| // Tell the renderer to suppress any further modal dialogs so that we can swap
|
| // it out. This must be done before canceling any current dialog, in case
|
| // there is a loop creating additional dialogs.
|
| - render_view_host_->SuppressDialogsUntilSwapOut();
|
| + render_frame_host_->render_view_host()->SuppressDialogsUntilSwapOut();
|
|
|
| // Now close any modal dialogs that would prevent us from swapping out. This
|
| // must be done separately from SwapOut, so that the PageGroupLoadDeferrer is
|
| @@ -452,14 +541,21 @@ void RenderViewHostManager::SwapOutOldPage() {
|
| // unload handler finishes and the navigation completes, we will send a
|
| // message to the ResourceDispatcherHost, allowing the pending RVH's response
|
| // to resume.
|
| - render_view_host_->SwapOut();
|
| + // Note: this must be done on the RFH or else we'll swap out the
|
| + // top-level page.
|
| + if (render_frame_host_->is_main_frame())
|
| + render_frame_host_->render_view_host()->SwapOut();
|
| + else
|
| + render_frame_host_->SwapOut();
|
|
|
| // ResourceDispatcherHost has told us to run the onunload handler, which
|
| // means it is not a download or unsafe page, and we are going to perform the
|
| - // navigation. Thus, we no longer need to remember that the RenderViewHost
|
| + // navigation. Thus, we no longer need to remember that the RenderFrameHost
|
| // is part of a pending cross-site request.
|
| - if (pending_render_view_host_)
|
| - pending_render_view_host_->SetHasPendingCrossSiteRequest(false);
|
| + if (pending_render_frame_host_) {
|
| + pending_render_frame_host_->render_view_host()->
|
| + SetHasPendingCrossSiteRequest(false);
|
| + }
|
| }
|
|
|
| void RenderViewHostManager::Observe(
|
| @@ -500,7 +596,7 @@ bool RenderViewHostManager::ShouldSwapProcessesForNavigation(
|
| // page and one isn't. If there's no curr_entry, check the current RVH's
|
| // site, which might already be committed to a Web UI URL (such as the NTP).
|
| const GURL& current_url = (curr_entry) ? curr_entry->GetURL() :
|
| - render_view_host_->GetSiteInstance()->GetSiteURL();
|
| + render_frame_host_->render_view_host()->GetSiteInstance()->GetSiteURL();
|
| BrowserContext* browser_context =
|
| delegate_->GetControllerForRenderManager().GetBrowserContext();
|
| if (WebUIControllerFactoryRegistry::GetInstance()->UseWebUIForURL(
|
| @@ -520,7 +616,7 @@ bool RenderViewHostManager::ShouldSwapProcessesForNavigation(
|
| }
|
|
|
| if (GetContentClient()->browser()->ShouldSwapProcessesForNavigation(
|
| - render_view_host_->GetSiteInstance(),
|
| + render_frame_host_->render_view_host()->GetSiteInstance(),
|
| curr_entry ? curr_entry->GetURL() : GURL(),
|
| new_entry->GetURL())) {
|
| return true;
|
| @@ -705,7 +801,7 @@ SiteInstance* RenderViewHostManager::GetSiteInstanceForEntry(
|
| }
|
| }
|
|
|
| -int RenderViewHostManager::CreateRenderView(
|
| +int RenderViewHostManager::CreateRenderFrame(
|
| SiteInstance* instance,
|
| int opener_route_id,
|
| bool swapped_out,
|
| @@ -716,49 +812,57 @@ int RenderViewHostManager::CreateRenderView(
|
| // Check if we've already created an RVH for this SiteInstance. If so, try
|
| // to re-use the existing one, which has already been initialized. We'll
|
| // remove it from the list of swapped out hosts if it commits.
|
| - RenderViewHostImpl* new_render_view_host = static_cast<RenderViewHostImpl*>(
|
| - GetSwappedOutRenderViewHost(instance));
|
| - if (new_render_view_host) {
|
| + RenderFrameHostImpl* new_render_frame_host =
|
| + GetSwappedOutRenderFrameHost(instance);
|
| + if (new_render_frame_host) {
|
| // Prevent the process from exiting while we're trying to use it.
|
| if (!swapped_out)
|
| - new_render_view_host->GetProcess()->AddPendingView();
|
| + new_render_frame_host->GetProcess()->AddPendingView();
|
| } else {
|
| - // Create a new RenderViewHost if we don't find an existing one.
|
| - new_render_view_host = static_cast<RenderViewHostImpl*>(
|
| - RenderViewHostFactory::Create(instance,
|
| - render_view_delegate_,
|
| - render_widget_delegate_,
|
| - MSG_ROUTING_NONE,
|
| - MSG_ROUTING_NONE,
|
| - swapped_out,
|
| - hidden));
|
| -
|
| - // If the new RVH is swapped out already, store it. Otherwise prevent the
|
| + // Create a new RenderFrameHost if we don't find an existing one. Start
|
| + // by finding or creating a RenderViewHost for it if needed.
|
| + FrameTree* frame_tree = render_view_delegate_->GetFrameTree();
|
| + int frame_routing_id = instance->GetProcess()->GetNextRoutingID();
|
| + RenderViewHostImpl* render_view_host =
|
| + frame_tree->GetRenderViewHostForNewFrame(instance, MSG_ROUTING_NONE,
|
| + frame_routing_id,
|
| + swapped_out, hidden);
|
| + new_render_frame_host = new RenderFrameHostImpl(render_view_host,
|
| + frame_tree,
|
| + frame_tree_node_,
|
| + frame_routing_id,
|
| + swapped_out);
|
| +
|
| + // If the new RFH is swapped out already, store it. Otherwise prevent the
|
| // process from exiting while we're trying to navigate in it.
|
| if (swapped_out) {
|
| - swapped_out_hosts_[instance->GetId()] = new_render_view_host;
|
| + swapped_out_hosts_[instance->GetId()] = new_render_frame_host;
|
| } else {
|
| - new_render_view_host->GetProcess()->AddPendingView();
|
| + new_render_frame_host->GetProcess()->AddPendingView();
|
| }
|
|
|
| - bool success = InitRenderView(new_render_view_host, opener_route_id);
|
| + bool success = InitRenderView(render_view_host, opener_route_id);
|
| if (success) {
|
| // Don't show the view until we get a DidNavigate from it.
|
| - new_render_view_host->GetView()->Hide();
|
| + render_view_host->GetView()->Hide();
|
| } else if (!swapped_out) {
|
| CancelPending();
|
| }
|
| }
|
|
|
| - // Use this as our new pending RVH if it isn't swapped out.
|
| + // Use this as our new pending RFH if it isn't swapped out.
|
| if (!swapped_out)
|
| - pending_render_view_host_ = new_render_view_host;
|
| + pending_render_frame_host_ = new_render_frame_host;
|
|
|
| - return new_render_view_host->GetRoutingID();
|
| + return new_render_frame_host->render_view_host()->GetRoutingID();
|
| }
|
|
|
| bool RenderViewHostManager::InitRenderView(RenderViewHost* render_view_host,
|
| int opener_route_id) {
|
| + // We may have initialized this RenderView for another RenderFrameHost.
|
| + if (render_view_host->IsRenderViewLive())
|
| + return true;
|
| +
|
| // If the pending navigation is to a WebUI and the RenderView is not in a
|
| // guest process, tell the RenderView about any bindings it will need enabled.
|
| if (pending_web_ui() && !render_view_host->GetProcess()->IsGuest())
|
| @@ -784,10 +888,10 @@ void RenderViewHostManager::CommitPending() {
|
| else if (!pending_and_current_web_ui_.get())
|
| web_ui_.reset();
|
|
|
| - // It's possible for the pending_render_view_host_ to be NULL when we aren't
|
| + // It's possible for the pending_render_frame_host_ to be NULL when we aren't
|
| // crossing process boundaries. If so, we just needed to handle the Web UI
|
| // committing above and we're done.
|
| - if (!pending_render_view_host_) {
|
| + if (!pending_render_frame_host_) {
|
| if (will_focus_location_bar)
|
| delegate_->SetFocusToLocationBar(false);
|
| return;
|
| @@ -796,90 +900,119 @@ void RenderViewHostManager::CommitPending() {
|
| // Remember if the page was focused so we can focus the new renderer in
|
| // that case.
|
| bool focus_render_view = !will_focus_location_bar &&
|
| - render_view_host_->GetView() && render_view_host_->GetView()->HasFocus();
|
| + render_frame_host_->render_view_host()->GetView() &&
|
| + render_frame_host_->render_view_host()->GetView()->HasFocus();
|
|
|
| - // Swap in the pending view and make it active. Also ensure the FrameTree
|
| - // stays in sync.
|
| - RenderViewHostImpl* old_render_view_host = render_view_host_;
|
| - render_view_host_ = pending_render_view_host_;
|
| - pending_render_view_host_ = NULL;
|
| - render_view_host_->AttachToFrameTree();
|
| + // Swap in the pending frame and make it active.
|
| + RenderFrameHostImpl* old_render_frame_host = render_frame_host_;
|
| + render_frame_host_ = pending_render_frame_host_;
|
| + pending_render_frame_host_ = NULL;
|
|
|
| // The process will no longer try to exit, so we can decrement the count.
|
| - render_view_host_->GetProcess()->RemovePendingView();
|
| + render_frame_host_->GetProcess()->RemovePendingView();
|
| +
|
| + // TODO(creis): As long as show/hide are on RVH, we don't want to do them for
|
| + // subframe navigations or they'll interfere with the top-level page.
|
| + bool is_subframe =
|
| + render_view_delegate_->GetFrameTree()->root()->render_manager() != this;
|
|
|
| // If the view is gone, then this RenderViewHost died while it was hidden.
|
| // We ignored the RenderProcessGone call at the time, so we should send it now
|
| // to make sure the sad tab shows up, etc.
|
| - if (!render_view_host_->GetView())
|
| - delegate_->RenderProcessGoneFromRenderManager(render_view_host_);
|
| - else if (!delegate_->IsHidden())
|
| - render_view_host_->GetView()->Show();
|
| + if (!render_frame_host_->render_view_host()->GetView()) {
|
| + delegate_->RenderProcessGoneFromRenderManager(
|
| + render_frame_host_->render_view_host());
|
| + } else if (!delegate_->IsHidden() && !is_subframe) {
|
| + render_frame_host_->render_view_host()->GetView()->Show();
|
| + }
|
|
|
| // Hide the old view now that the new one is visible.
|
| - if (old_render_view_host->GetView()) {
|
| - old_render_view_host->GetView()->Hide();
|
| - old_render_view_host->WasSwappedOut();
|
| + // TODO(creis): We don't want to hide the top-level view based on a frame
|
| + // swap. Hack for now.
|
| + if (old_render_frame_host->render_view_host()->GetView()) {
|
| + if (!is_subframe) {
|
| + old_render_frame_host->render_view_host()->GetView()->Hide();
|
| + old_render_frame_host->render_view_host()->WasSwappedOut();
|
| + } else {
|
| + // TODO(creis): We'll need to set this back to false when navigating a
|
| + // subframe RFH, but we can't navigate a subframe RFH yet.
|
| + old_render_frame_host->set_swapped_out(true);
|
| + }
|
| }
|
|
|
| // Make sure the size is up to date. (Fix for bug 1079768.)
|
| delegate_->UpdateRenderViewSizeForRenderManager();
|
|
|
| - if (will_focus_location_bar)
|
| + if (will_focus_location_bar) {
|
| delegate_->SetFocusToLocationBar(false);
|
| - else if (focus_render_view && render_view_host_->GetView())
|
| - RenderWidgetHostViewPort::FromRWHV(render_view_host_->GetView())->Focus();
|
| + } else if (focus_render_view &&
|
| + render_frame_host_->render_view_host()->GetView()) {
|
| + RenderWidgetHostViewPort::FromRWHV(
|
| + render_frame_host_->render_view_host()->GetView())->Focus();
|
| + }
|
|
|
| - // Notify that we've swapped RenderViewHosts. We do this
|
| - // before shutting down the RVH so that we can clean up
|
| - // RendererResources related to the RVH first.
|
| - delegate_->NotifySwappedFromRenderManager(old_render_view_host,
|
| - render_view_host_);
|
| + // Notify that we've swapped RenderFrameHosts. We do this
|
| + // before shutting down the RFH so that we can clean up
|
| + // RendererResources related to the RFH first.
|
| + // TODO(creis): Only do this on top-level RFHs for now, and later
|
| + // update it to pass the RFHs.
|
| + if (!is_subframe) {
|
| + delegate_->NotifySwappedFromRenderManager(
|
| + old_render_frame_host->render_view_host(),
|
| + render_frame_host_->render_view_host());
|
| + }
|
|
|
| - // If the pending view was on the swapped out list, we can remove it.
|
| - swapped_out_hosts_.erase(render_view_host_->GetSiteInstance()->GetId());
|
| + // If the pending frame was on the swapped out list, we can remove it.
|
| + swapped_out_hosts_.erase(render_frame_host_->render_view_host()->
|
| + GetSiteInstance()->GetId());
|
|
|
| - // If there are no active RVHs in this SiteInstance, it means that
|
| - // this RVH was the last active one in the SiteInstance. Now that we
|
| - // know that all RVHs are swapped out, we can delete all the RVHs in
|
| + // If there are no active RFHs in this SiteInstance, it means that
|
| + // this RFH was the last active one in the SiteInstance. Now that we
|
| + // know that all RFHs are swapped out, we can delete all the RFHs in
|
| // this SiteInstance.
|
| - if (!static_cast<SiteInstanceImpl*>(old_render_view_host->GetSiteInstance())->
|
| - active_view_count()) {
|
| - ShutdownRenderViewHostsInSiteInstance(
|
| - old_render_view_host->GetSiteInstance()->GetId());
|
| - // This is deleted while cleaning up the SitaInstance's views.
|
| - old_render_view_host = NULL;
|
| - } else if (old_render_view_host->IsRenderViewLive()) {
|
| + // TODO(creis): the ShutdownRFHs call doesn't work until we can iterate over
|
| + // all RFHs. Let's skip it for now and just swap out like we used to.
|
| + /*if (!static_cast<SiteInstanceImpl*>(
|
| + old_render_frame_host->render_view_host()->GetSiteInstance())->
|
| + active_view_count()) {
|
| + ShutdownRenderFrameHostsInSiteInstance(
|
| + old_render_frame_host->render_view_host()->GetSiteInstance()->GetId());
|
| + // This is deleted while cleaning up the SiteInstance's views.
|
| + old_render_frame_host = NULL;
|
| + } else*/
|
| + if (old_render_frame_host->render_view_host()->IsRenderViewLive()) {
|
| // If the old RVH is live, we are swapping it out and should keep track of
|
| // it in case we navigate back to it.
|
| - DCHECK(old_render_view_host->is_swapped_out());
|
| + DCHECK(old_render_frame_host->is_swapped_out() ||
|
| + old_render_frame_host->render_view_host()->is_swapped_out());
|
| // Temp fix for http://crbug.com/90867 until we do a better cleanup to make
|
| // sure we don't get different rvh instances for the same site instance
|
| // in the same rvhmgr.
|
| // TODO(creis): Clean this up.
|
| int32 old_site_instance_id =
|
| - old_render_view_host->GetSiteInstance()->GetId();
|
| - RenderViewHostMap::iterator iter =
|
| + old_render_frame_host->render_view_host()->GetSiteInstance()->GetId();
|
| + RenderFrameHostMap::iterator iter =
|
| swapped_out_hosts_.find(old_site_instance_id);
|
| if (iter != swapped_out_hosts_.end() &&
|
| - iter->second != old_render_view_host) {
|
| - // Shutdown the RVH that will be replaced in the map to avoid a leak.
|
| - iter->second->Shutdown();
|
| + iter->second != old_render_frame_host) {
|
| + // Delete the RFH that will be replaced in the map to avoid a leak.
|
| + delete iter->second;
|
| }
|
| - swapped_out_hosts_[old_site_instance_id] = old_render_view_host;
|
| + swapped_out_hosts_[old_site_instance_id] = old_render_frame_host;
|
| } else {
|
| - old_render_view_host->Shutdown();
|
| - old_render_view_host = NULL; // Shutdown() deletes it.
|
| + delete old_render_frame_host;
|
| }
|
| }
|
|
|
| -void RenderViewHostManager::ShutdownRenderViewHostsInSiteInstance(
|
| +void RenderViewHostManager::ShutdownRenderFrameHostsInSiteInstance(
|
| int32 site_instance_id) {
|
| - // First remove any swapped out RVH for this SiteInstance from our
|
| + // First remove any swapped out RFH for this SiteInstance from our
|
| // list.
|
| swapped_out_hosts_.erase(site_instance_id);
|
|
|
| - scoped_ptr<RenderWidgetHostIterator> widgets(
|
| + // TODO(creis): We can't iterate over widgets to find all frames.
|
| + // Must have another way to find all RFHs in the SiteInstance.
|
| + /*scoped_ptr<RenderWidgetHostIterator> widgets(
|
| RenderWidgetHostImpl::GetAllRenderWidgetHosts());
|
| while (RenderWidgetHost* widget = widgets->GetNextHost()) {
|
| if (!widget->IsRenderView())
|
| @@ -888,22 +1021,23 @@ void RenderViewHostManager::ShutdownRenderViewHostsInSiteInstance(
|
| static_cast<RenderViewHostImpl*>(RenderViewHost::From(widget));
|
| if (site_instance_id == rvh->GetSiteInstance()->GetId())
|
| rvh->Shutdown();
|
| - }
|
| + }*/
|
| }
|
|
|
| -RenderViewHostImpl* RenderViewHostManager::UpdateRendererStateForNavigate(
|
| +RenderFrameHostImpl* RenderViewHostManager::UpdateRendererStateForNavigate(
|
| const NavigationEntryImpl& entry) {
|
| // If we are cross-navigating, then we want to get back to normal and navigate
|
| // as usual.
|
| if (cross_navigation_pending_) {
|
| - if (pending_render_view_host_)
|
| + if (pending_render_frame_host_)
|
| CancelPending();
|
| cross_navigation_pending_ = false;
|
| }
|
|
|
| - // render_view_host_ will not be deleted before the end of this method, so we
|
| + // render_frame_host_ will not be deleted before the end of this method, so we
|
| // don't have to worry about this SiteInstance's ref count dropping to zero.
|
| - SiteInstance* curr_instance = render_view_host_->GetSiteInstance();
|
| + SiteInstance* curr_instance =
|
| + render_frame_host_->render_view_host()->GetSiteInstance();
|
|
|
| // Determine if we need a new SiteInstance for this entry.
|
| // Again, new_instance won't be deleted before the end of this method, so it
|
| @@ -939,13 +1073,13 @@ RenderViewHostImpl* RenderViewHostManager::UpdateRendererStateForNavigate(
|
|
|
| // Create a non-swapped-out pending RVH with the given opener and navigate
|
| // it.
|
| - int route_id = CreateRenderView(new_instance, opener_route_id, false,
|
| - delegate_->IsHidden());
|
| + int route_id = CreateRenderFrame(new_instance, opener_route_id, false,
|
| + delegate_->IsHidden());
|
| if (route_id == MSG_ROUTING_NONE)
|
| return NULL;
|
|
|
| // Check if our current RVH is live before we set up a transition.
|
| - if (!render_view_host_->IsRenderViewLive()) {
|
| + if (!render_frame_host_->render_view_host()->IsRenderViewLive()) {
|
| if (!cross_navigation_pending_) {
|
| // The current RVH is not live. There's no reason to sit around with a
|
| // sad tab or a newly created RVH while we wait for the pending RVH to
|
| @@ -953,10 +1087,10 @@ RenderViewHostImpl* RenderViewHostManager::UpdateRendererStateForNavigate(
|
| // cross-navigating (Note that we don't care about on{before}unload
|
| // handlers if the current RVH isn't live.)
|
| CommitPending();
|
| - return render_view_host_;
|
| + return render_frame_host_;
|
| } else {
|
| NOTREACHED();
|
| - return render_view_host_;
|
| + return render_frame_host_;
|
| }
|
| }
|
| // Otherwise, it's safe to treat this as a pending cross-site transition.
|
| @@ -967,7 +1101,8 @@ RenderViewHostImpl* RenderViewHostManager::UpdateRendererStateForNavigate(
|
| // Navigate message) until we hear back from the old renderer's
|
| // beforeunload handler. If the handler returns false, we'll have to
|
| // cancel the request.
|
| - DCHECK(!pending_render_view_host_->are_navigations_suspended());
|
| + DCHECK(!pending_render_frame_host_->render_view_host()->
|
| + are_navigations_suspended());
|
| bool is_transfer =
|
| entry.transferred_global_request_id() != GlobalRequestID();
|
| if (is_transfer) {
|
| @@ -979,19 +1114,21 @@ RenderViewHostImpl* RenderViewHostManager::UpdateRendererStateForNavigate(
|
| // Also make sure the old render view stops, in case a load is in
|
| // progress. (We don't want to do this for transfers, since it will
|
| // interrupt the transfer with an unexpected DidStopLoading.)
|
| - render_view_host_->Send(
|
| - new ViewMsg_Stop(render_view_host_->GetRoutingID()));
|
| + render_frame_host_->render_view_host()->Send(new ViewMsg_Stop(
|
| + render_frame_host_->render_view_host()->GetRoutingID()));
|
|
|
| - pending_render_view_host_->SetNavigationsSuspended(true,
|
| - base::TimeTicks());
|
| + pending_render_frame_host_->render_view_host()->
|
| + SetNavigationsSuspended(true, base::TimeTicks());
|
|
|
| // Tell the CrossSiteRequestManager that this RVH has a pending cross-site
|
| // request, so that ResourceDispatcherHost will know to tell us to run the
|
| // old page's unload handler before it sends the response.
|
| - pending_render_view_host_->SetHasPendingCrossSiteRequest(true);
|
| + // TODO(creis): This needs to be on the RFH.
|
| + pending_render_frame_host_->render_view_host()->
|
| + SetHasPendingCrossSiteRequest(true);
|
| }
|
|
|
| - // We now have a pending RVH.
|
| + // We now have a pending RFH.
|
| DCHECK(!cross_navigation_pending_);
|
| cross_navigation_pending_ = true;
|
|
|
| @@ -1000,9 +1137,9 @@ RenderViewHostImpl* RenderViewHostManager::UpdateRendererStateForNavigate(
|
| // doesn't otherwise know that the cross-site request is happening. This
|
| // will trigger a call to ShouldClosePage with the reply.
|
| if (!is_transfer)
|
| - render_view_host_->FirePageBeforeUnload(true);
|
| + render_frame_host_->render_view_host()->FirePageBeforeUnload(true);
|
|
|
| - return pending_render_view_host_;
|
| + return pending_render_frame_host_;
|
| } else {
|
| if (ShouldReuseWebUI(curr_entry, &entry)) {
|
| pending_web_ui_.reset();
|
| @@ -1011,50 +1148,57 @@ RenderViewHostImpl* RenderViewHostManager::UpdateRendererStateForNavigate(
|
| SetPendingWebUI(entry);
|
|
|
| // Make sure the new RenderViewHost has the right bindings.
|
| - if (pending_web_ui() && !render_view_host_->GetProcess()->IsGuest())
|
| - render_view_host_->AllowBindings(pending_web_ui()->GetBindings());
|
| + if (pending_web_ui() && !render_frame_host_->GetProcess()->IsGuest()) {
|
| + render_frame_host_->render_view_host()->AllowBindings(
|
| + pending_web_ui()->GetBindings());
|
| + }
|
| }
|
|
|
| - if (pending_web_ui() && render_view_host_->IsRenderViewLive())
|
| - pending_web_ui()->GetController()->RenderViewReused(render_view_host_);
|
| + if (pending_web_ui() &&
|
| + render_frame_host_->render_view_host()->IsRenderViewLive()) {
|
| + pending_web_ui()->GetController()->RenderViewReused(
|
| + render_frame_host_->render_view_host());
|
| + }
|
|
|
| // The renderer can exit view source mode when any error or cancellation
|
| // happen. We must overwrite to recover the mode.
|
| if (entry.IsViewSourceMode()) {
|
| - render_view_host_->Send(
|
| - new ViewMsg_EnableViewSourceMode(render_view_host_->GetRoutingID()));
|
| + render_frame_host_->render_view_host()->Send(
|
| + new ViewMsg_EnableViewSourceMode(
|
| + render_frame_host_->render_view_host()->GetRoutingID()));
|
| }
|
| }
|
|
|
| - // Same SiteInstance can be used. Navigate render_view_host_ if we are not
|
| + // Same SiteInstance can be used. Navigate render_frame_host_ if we are not
|
| // cross navigating.
|
| DCHECK(!cross_navigation_pending_);
|
| - return render_view_host_;
|
| + return render_frame_host_;
|
| }
|
|
|
| void RenderViewHostManager::CancelPending() {
|
| - RenderViewHostImpl* pending_render_view_host = pending_render_view_host_;
|
| - pending_render_view_host_ = NULL;
|
| + RenderFrameHostImpl* pending_render_frame_host = pending_render_frame_host_;
|
| + pending_render_frame_host_ = NULL;
|
|
|
| RenderViewDevToolsAgentHost::OnCancelPendingNavigation(
|
| - pending_render_view_host,
|
| - render_view_host_);
|
| + pending_render_frame_host->render_view_host(),
|
| + render_frame_host_->render_view_host());
|
|
|
| // We no longer need to prevent the process from exiting.
|
| - pending_render_view_host->GetProcess()->RemovePendingView();
|
| + pending_render_frame_host->GetProcess()->RemovePendingView();
|
|
|
| - // The pending RVH may already be on the swapped out list if we started to
|
| + // The pending RFH may already be on the swapped out list if we started to
|
| // swap it back in and then canceled. If so, make sure it gets swapped out
|
| // again. If it's not on the swapped out list (e.g., aborting a pending
|
| // load), then it's safe to shut down.
|
| - if (IsOnSwappedOutList(pending_render_view_host)) {
|
| + if (IsOnSwappedOutList(pending_render_frame_host)) {
|
| // Any currently suspended navigations are no longer needed.
|
| - pending_render_view_host->CancelSuspendedNavigations();
|
| + pending_render_frame_host->render_view_host()->CancelSuspendedNavigations();
|
|
|
| - pending_render_view_host->SwapOut();
|
| + // TODO(creis): We need to swap out the RFH.
|
| + pending_render_frame_host->render_view_host()->SwapOut();
|
| } else {
|
| // We won't be coming back, so shut this one down.
|
| - pending_render_view_host->Shutdown();
|
| + delete pending_render_frame_host;
|
| }
|
|
|
| pending_web_ui_.reset();
|
| @@ -1062,48 +1206,70 @@ void RenderViewHostManager::CancelPending() {
|
| }
|
|
|
| void RenderViewHostManager::RenderViewDeleted(RenderViewHost* rvh) {
|
| + // Make sure deleted RVHs are not kept in the swapped out list while we are
|
| + // still alive. (If render_frame_host_ is null, we're already being deleted.)
|
| + if (!render_frame_host_)
|
| + return;
|
| +
|
| // We are doing this in order to work around and to track a crasher
|
| - // (http://crbug.com/23411) where it seems that pending_render_view_host_ is
|
| + // (http://crbug.com/23411) where it seems that pending_render_frame_host_ is
|
| // deleted (not sure from where) but not NULLed.
|
| - if (rvh == pending_render_view_host_) {
|
| + if (pending_render_frame_host_ &&
|
| + rvh == pending_render_frame_host_->render_view_host()) {
|
| // If you hit this NOTREACHED, please report it in the following bug
|
| // http://crbug.com/23411 Make sure to include what you were doing when it
|
| // happened (navigating to a new page, closing a tab...) and if you can
|
| // reproduce.
|
| NOTREACHED();
|
| - pending_render_view_host_ = NULL;
|
| + // TODO(creis): Remove all this (or remove all RFHs that it affects).
|
| + pending_render_frame_host_ = NULL;
|
| }
|
|
|
| - // Make sure deleted RVHs are not kept in the swapped out list while we are
|
| - // still alive. (If render_view_host_ is null, we're already being deleted.)
|
| - if (!render_view_host_)
|
| - return;
|
| // We can't look it up by SiteInstance ID, which may no longer be valid.
|
| - for (RenderViewHostMap::iterator iter = swapped_out_hosts_.begin();
|
| + for (RenderFrameHostMap::iterator iter = swapped_out_hosts_.begin();
|
| iter != swapped_out_hosts_.end();
|
| ++iter) {
|
| - if (iter->second == rvh) {
|
| + if (iter->second->render_view_host() == rvh) {
|
| swapped_out_hosts_.erase(iter);
|
| break;
|
| }
|
| }
|
| }
|
|
|
| -bool RenderViewHostManager::IsOnSwappedOutList(RenderViewHost* rvh) const {
|
| - if (!rvh->GetSiteInstance())
|
| +bool RenderViewHostManager::IsRVHOnSwappedOutList(
|
| + RenderViewHostImpl* rvh) const {
|
| + RenderFrameHostImpl* render_frame_host = GetSwappedOutRenderFrameHost(
|
| + rvh->GetSiteInstance());
|
| + if (!render_frame_host)
|
| + return false;
|
| + return IsOnSwappedOutList(render_frame_host);
|
| +}
|
| +
|
| +bool RenderViewHostManager::IsOnSwappedOutList(RenderFrameHostImpl* rfh) const {
|
| + if (!rfh->render_view_host()->GetSiteInstance())
|
| return false;
|
|
|
| - RenderViewHostMap::const_iterator iter = swapped_out_hosts_.find(
|
| - rvh->GetSiteInstance()->GetId());
|
| + RenderFrameHostMap::const_iterator iter = swapped_out_hosts_.find(
|
| + rfh->render_view_host()->GetSiteInstance()->GetId());
|
| if (iter == swapped_out_hosts_.end())
|
| return false;
|
|
|
| - return iter->second == rvh;
|
| + return iter->second == rfh;
|
| }
|
|
|
| RenderViewHostImpl* RenderViewHostManager::GetSwappedOutRenderViewHost(
|
| - SiteInstance* instance) {
|
| - RenderViewHostMap::iterator iter = swapped_out_hosts_.find(instance->GetId());
|
| + SiteInstance* instance) const {
|
| + RenderFrameHostImpl* render_frame_host =
|
| + GetSwappedOutRenderFrameHost(instance);
|
| + if (render_frame_host)
|
| + return render_frame_host->render_view_host();
|
| + return NULL;
|
| +}
|
| +
|
| +RenderFrameHostImpl* RenderViewHostManager::GetSwappedOutRenderFrameHost(
|
| + SiteInstance* instance) const {
|
| + RenderFrameHostMap::const_iterator iter =
|
| + swapped_out_hosts_.find(instance->GetId());
|
| if (iter != swapped_out_hosts_.end())
|
| return iter->second;
|
|
|
|
|