chrome/browser/extensions/api/web_navigation/web_navigation_api.cc - Issue 30323002: [DRAFT] Create RenderFrameHostManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

Issue 30323002: [DRAFT] Create RenderFrameHostManager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

index f4ecce5bff562e4b0135fe7130af46974987b501..d001a8ca0a7a90297ccd10729327b8aa1d72484b 100644

--- a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

@@ -574,7 +574,8 @@ void WebNavigationTabObserver::DidFinishLoad(

validated_url == GURL(content::kAboutBlankURL)))

<< "validated URL is " << validated_url << " but we expected "

<< navigation_state_.GetUrl(frame_id);

- DCHECK_EQ(navigation_state_.IsMainFrame(frame_id), is_main_frame);

+ // TODO(creis): Diagnose.

+ //DCHECK_EQ(navigation_state_.IsMainFrame(frame_id), is_main_frame);

// The load might already have finished by the time we finished parsing. For

// compatibility reasons, we artifically delay the load completed signal until