Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 30323002: [DRAFT] Create RenderFrameHostManager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index dbe8972e2ac3a120d554c8a24fde378d49be2942..108c1f278e7dfffa68ecfae4ac5374b26fb6afad 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -59,8 +59,13 @@ class CONTENT_EXPORT RenderFrameHostImpl : public RenderFrameHost {
bool is_swapped_out() { return is_swapped_out_; }
- // TODO(nasko): This should be removed and replaced by RenderProcessHost.
- RenderViewHostImpl* render_view_host_; // Not owned.
+ // For now, RenderFrameHosts indirectly keep RenderViewHosts alive via the
+ // refcount on FrameTree. This allows each RenderFrameHostManager to just
+ // care about RenderFrameHosts, while ensuring we have a RenderViewHost for
+ // each RenderFrameHost.
+ // TODO(creis): RenderViewHost will eventually go away and be replaced with
+ // some form of page context.
+ RenderViewHostImpl* render_view_host_;
// Reference to the whole frame tree that this RenderFrameHost belongs too.
// Allows this RenderFrameHost to add and remove nodes in response to
« no previous file with comments | « content/browser/frame_host/navigation_entry_impl.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698