Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 303223007: [NaCl SDK] nacl_io: Run clang-format over nacl_io sources. (Closed)

Created:
6 years, 6 months ago by Sam Clegg
Modified:
6 years, 6 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org
Visibility:
Public.

Description

[NaCl SDK] nacl_io: Run clang-format over nacl_io sources. This change contains most of the changes that clang-format wanted to make to nacl_io. I left out a few that we not obviously better, mostly related to complex PPAPI macros. R=binji@chromium.org, binji BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273918

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+770 lines, -509 lines) Patch
M native_client_sdk/src/libraries/nacl_io/devfs/dev_fs.cc View 4 chunks +22 lines, -9 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/devfs/jspipe_event_emitter.h View 1 chunk +6 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/devfs/jspipe_event_emitter.cc View 7 chunks +26 lines, -26 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/devfs/jspipe_node.h View 1 chunk +3 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/devfs/jspipe_node.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/devfs/tty_node.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/dir_node.cc View 1 chunk +3 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/event_emitter.h View 2 chunks +0 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/event_emitter.cc View 1 chunk +2 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/event_listener.h View 3 chunks +1 line, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/event_listener.cc View 5 chunks +3 lines, -7 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/fifo_char.h View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/fifo_char.cc View 1 chunk +1 line, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/filesystem.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/fuse.h View 4 chunks +29 lines, -9 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/fusefs/fuse_fs.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/fusefs/fuse_fs_factory.cc View 1 chunk +2 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/host_resolver.h View 1 chunk +7 lines, -5 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/host_resolver.cc View 6 chunks +8 lines, -9 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/html5fs/html5_fs.cc View 4 chunks +12 lines, -6 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/html5fs/html5_fs_node.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/httpfs/http_fs.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.cc View 3 chunks +11 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/include/sys/mount.h View 1 chunk +6 lines, -3 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/include/sys/poll.h View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/include/sys/termios.h View 1 chunk +7 lines, -8 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/include/sys/utsname.h View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/ioctl.h View 1 chunk +0 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_handle.h View 1 chunk +0 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_handle.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_intercept.h View 5 chunks +43 lines, -22 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_intercept.cc View 13 chunks +58 lines, -33 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_object.h View 2 chunks +6 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_object.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_proxy.h View 6 chunks +31 lines, -28 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_wrap.h View 2 chunks +17 lines, -10 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_wrap_bionic.cc View 16 chunks +63 lines, -57 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_wrap_dummy.cc View 4 chunks +9 lines, -5 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_wrap_glibc.cc View 18 chunks +97 lines, -70 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_wrap_newlib.cc View 6 chunks +50 lines, -41 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_wrap_real.h View 1 chunk +9 lines, -5 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/memfs/mem_fs.cc View 1 chunk +2 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/memfs/mem_fs_node.cc View 1 chunk +2 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/nacl_io.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/node.cc View 7 chunks +53 lines, -18 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/ostermios.h View 1 chunk +2 lines, -3 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/ostime.h View 2 chunks +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/passthroughfs/passthrough_fs.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/path.h View 1 chunk +2 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/path.cc View 9 chunks +27 lines, -16 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/pepper/all_interfaces.h View 1 chunk +0 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/pepper_interface.h View 2 chunks +2 lines, -3 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/pepper_interface.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/pepper_interface_delegate.h View 3 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/pepper_interface_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/pepper_interface_dummy.h View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/pipe/pipe_event_emitter.cc View 1 chunk +2 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/real_pepper_interface.h View 3 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/real_pepper_interface.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/socket/fifo_packet.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/socket/packet.cc View 1 chunk +2 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/socket/socket_node.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/socket/tcp_event_emitter.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/socket/tcp_node.cc View 1 chunk +3 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/socket/udp_node.cc View 1 chunk +3 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/stream/stream_event_emitter.cc View 1 chunk +2 lines, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/stream/stream_fs.cc View 1 chunk +18 lines, -6 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/stream/stream_node.cc View 2 chunks +12 lines, -5 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/syscalls/inet_ntop.cc View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sam Clegg
6 years, 6 months ago (2014-05-29 22:31:45 UTC) #1
binji
lgtm
6 years, 6 months ago (2014-05-29 22:50:04 UTC) #2
Sam Clegg
6 years, 6 months ago (2014-05-30 22:40:00 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r273918 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698