Explicitly print diff stats to sys.stdout, if possible.

git_cl.py

Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index e8695e82eff5e402b5d7ee09ecaa23216ea75c6b..f8668c1a8b9fcaf514ab7a620981c486fb671af3 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -259,10 +259,14 @@ def print_stats(similarity, find_copies, args):
   else:
     similarity_options = ['-M%s' % similarity]
 
+  try:
+    stdout = sys.stdout.fileno()

[Dirk Pranke, 2014/05/29 20:31:36]

drive-by nit: sys.stdout works fine, you don't need the fileno() ...

[szager1, 2014/05/29 20:48:04]

There is some existing code that replaces sys.stdout with a StringIO, and that
won't work, because there's no file descriptor associated with a StringIO.  So,
to do what you say, I'd have to:

try:
  sys.stdout.fileno()
  stdout = sys.stdout
except AttributeError:
  stdout = None

... which seems silly to me.

[Dirk Pranke, 2014/05/29 21:10:47]

You lost me, or maybe I'm not understanding something. subprocess2.call() should
be just fine w/ receiving a file-like object for the stdout= keyword parameter,
and so passing a StringIO should be fine as well. 

+  except AttributeError:
+    stdout = None
   return subprocess2.call(
       ['git',
        'diff', '--no-ext-diff', '--stat'] + similarity_options + args,
-      env=env)
+      stdout=stdout, env=env)
 
 
 class Settings(object):