Issue 3032037: [mac] fix official build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3032037: [mac] fix official build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by Mattias Nissler

Modified:
4 years ago

Reviewers:
Mark Mentovai - out til August, Elliot Glaysher

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org

Visibility:
Public.

Description

[mac] fix official build Directly include base/string_util.h, which was removed in r53969 from the indirectly included base/command_line.h BUG=none TEST=Mac official builder goes green. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54140

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use GetSwitchValueASCII() #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/app/breakpad_mac.mm	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Trybot results:

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai - out til August

http://codereview.chromium.org/3032037/diff/1/2 File chrome/app/breakpad_mac.mm (right): http://codereview.chromium.org/3032037/diff/1/2#newcode138 chrome/app/breakpad_mac.mm:138: std::string guid = WideToASCII( A better choice would be ...

4 years, 10 months ago (2010-07-29 16:20:12 UTC) #1

Mattias Nissler

4 years, 10 months ago (2010-07-29 16:44:24 UTC) #2

LGTM

Expand Messages | Collapse Messages