Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 303163006: Make mojo handle encoding and validation follow the depth-first traversal order. (Closed)

Created:
6 years, 6 months ago by yzshen1
Modified:
6 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Make mojo message building and validation follow the depth-first traversal order. With this CL, the encoded handles will comply with the restriction that "If handle X is prior to handle Y in the depth-first traversal order and both of them are valid, then the value of X should be smaller than that of Y." BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274111

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl View 1 2 2 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yzshen1
Hi, Darin. Would you please take a look? Thanks!
6 years, 6 months ago (2014-05-30 23:11:14 UTC) #1
darin (slow to review)
LGTM Maybe this could be tested using validation_unittest.cc?
6 years, 6 months ago (2014-05-30 23:32:18 UTC) #2
yzshen1
Yes. I am planning to work on the tests. :) On Fri, May 30, 2014 ...
6 years, 6 months ago (2014-05-30 23:33:11 UTC) #3
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 6 months ago (2014-05-31 23:29:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/303163006/40001
6 years, 6 months ago (2014-05-31 23:29:48 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-01 12:17:40 UTC) #6
Message was sent while issue was closed.
Change committed as 274111

Powered by Google App Engine
This is Rietveld 408576698