Source/core/dom/Node.idl - Issue 303163002: Node.textContent setter should treat undefined the same way as null

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Node.idl

Issue 303163002: Node.textContent setter should treat undefined the same way as null (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Node.idl

diff --git a/Source/core/dom/Node.idl b/Source/core/dom/Node.idl

index b8a947fa7416196941f7a09b40eede3e916ef553..a033cd63f0521b39020cab7ec03667169eac5ea9 100644

--- a/Source/core/dom/Node.idl

+++ b/Source/core/dom/Node.idl

@@ -67,7 +67,7 @@

// Introduced in DOM Level 3:

[TreatReturnedNullStringAs=Null] readonly attribute DOMString baseURI;

- [TreatReturnedNullStringAs=Null, TreatNullAs=NullString, CustomElementCallbacks] attribute DOMString textContent;

+ [TreatReturnedNullStringAs=Null, TreatNullAs=NullString, TreatUndefinedAs=NullString, CustomElementCallbacks] attribute DOMString textContent;

arv (Not doing code reviews) 2014/05/29 16:14:51 Do we have an open bug on implementing DOMString?

[MeasureAs=NodeIsSameNode] boolean isSameNode([Default=Undefined] optional Node other); // Removed in DOM4.

boolean isEqualNode(Node other);