Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 303133008: Implement generalized file preparation utility function for apps. (Closed)

Created:
6 years, 6 months ago by kinaba
Modified:
6 years, 6 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Implement generalized file preparation utility function for apps. The previous implementation worked only for Google Drive filesystem. The new implementation in the current CL generally supports all volumes accessible from Chrome OS file manager, in particular including MTP devices and file systems provided by fileSystemProvider extensions. BUG=367028 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274222

Patch Set 1 #

Patch Set 2 : Fix relay creation position #

Patch Set 3 : Remove obsolete thread assertion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -16 lines) Patch
M chrome/browser/chromeos/file_manager/filesystem_api_util.cc View 1 2 5 chunks +68 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kinaba
PTAL. Note that the implemented behavior (if exists=>ok, else =>create) is slightly mismatching with the ...
6 years, 6 months ago (2014-06-02 07:25:14 UTC) #1
mtomasz
lgtm
6 years, 6 months ago (2014-06-02 07:43:23 UTC) #2
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 6 months ago (2014-06-02 08:15:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/303133008/50001
6 years, 6 months ago (2014-06-02 08:16:04 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 13:21:33 UTC) #5
Message was sent while issue was closed.
Change committed as 274222

Powered by Google App Engine
This is Rietveld 408576698