Added net_log logging statments for CertVerifyResult

net/cert/multi_threaded_cert_verifier.h

Index: net/cert/multi_threaded_cert_verifier.h
diff --git a/net/cert/multi_threaded_cert_verifier.h b/net/cert/multi_threaded_cert_verifier.h
index 8f00ebe301f93fed1620a5d700642fb931e7d78a..2a26561d647dbaf06536c0784ec1e3b88722d631 100644
--- a/net/cert/multi_threaded_cert_verifier.h
+++ b/net/cert/multi_threaded_cert_verifier.h
@@ -13,10 +13,12 @@
 #include "base/gtest_prod_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/threading/non_thread_safe.h"
+#include "base/values.h"
 #include "net/base/completion_callback.h"
 #include "net/base/expiring_cache.h"
 #include "net/base/hash_value.h"
 #include "net/base/net_export.h"
+#include "net/base/net_log.h"
 #include "net/cert/cert_database.h"
 #include "net/cert/cert_verifier.h"
 #include "net/cert/cert_verify_result.h"
@@ -169,4 +171,10 @@ class NET_EXPORT_PRIVATE MultiThreadedCertVerifier
 
 }  // namespace net
 
+namespace {

[Ryan Sleevi, 2014/05/30 22:46:24]

Short answer: Don't use unnamed namespaces in .h files (see "Decision" in
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Namesp...
)

Long answer (feel free to skip): When the C++ compiler encounters an unnamed
namespace, it generates a new unique namespace within the translation unit
(logical file being compiled). What this means is that when two files - a.cc and
b.cc - include b.h (which has an unnamed namespace), they will create new names
for this namespace. Assuming the definition is within b.cc, this creates an
issue.

All the functions within b.cc can see the 'compiler-generated' namespace (let's
call it __b__) from including b.h, and it knows to place
CertVerifyResultCallback within that namespace when it encounters the definition
in b.cc. However, when a.cc is compiled, it generates a different namespace
(let's call it __a__)

When the linker tries to link a.cc and b.cc to produce a.exe, it attempts to
find __a__::CertVerifyResultCallback, which a.cc depends on, but it can't. This
is because it was actually instantiated in b.cc, which placed it in
__b__::CertVerifyResultCallback.

This is the much longer-winded way of explaining why it doesn't work :)

The solution is to move this into the .cc file, which I'll annotate.

[mshelley, 2014/05/31 00:38:19]

Done.

+base::Value* CertVerifyResultCallback(net::CertVerifyResult verify_result,
+                                      net::NetLog::LogLevel log_level);
+}
+
 #endif  // NET_CERT_MULTI_THREADED_CERT_VERIFIER_H_
+