Added net_log logging statments for CertVerifyResult

net/cert/multi_threaded_cert_verifier.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_CERT_MULTI_THREADED_CERT_VERIFIER_H_
 #define NET_CERT_MULTI_THREADED_CERT_VERIFIER_H_
 
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/threading/non_thread_safe.h"
+#include "base/values.h"

[Ryan Sleevi, 2014/05/31 00:53:02]

So, had we needed 174-175 (which we don't, below), the fun part is, we wouldn't
need to include this header.

http://www.chromium.org/developers/coding-style/cpp-dos-and-donts lists a
variety of cases where forward declaration (
http://en.wikipedia.org/wiki/Forward_declaration#Classes ) would suffice.

In this world (read: you do NOT need to do this for this CL, because of comments
below), you would do

namespace base {
class Value;
}  // namespace base

You can see the example of forward declaration in use on lines 29-33 - we can
declare these classes, without having to include their respective headers /
declarations.

[mshelley, 2014/05/31 01:50:39]

Done.

 #include "net/base/completion_callback.h"
 #include "net/base/expiring_cache.h"
 #include "net/base/hash_value.h"
 #include "net/base/net_export.h"
+#include "net/base/net_log.h"
 #include "net/cert/cert_database.h"
 #include "net/cert/cert_verifier.h"
 #include "net/cert/cert_verify_result.h"
 #include "net/cert/x509_cert_types.h"
 
 namespace net {
 
 class CertTrustAnchorProvider;
 class CertVerifierJob;
 class CertVerifierRequest;
@@ skipping 132 matching lines @@
 
   scoped_refptr<CertVerifyProc> verify_proc_;
 
   CertTrustAnchorProvider* trust_anchor_provider_;
 
   DISALLOW_COPY_AND_ASSIGN(MultiThreadedCertVerifier);
 };
 
 }  // namespace net
 
+base::Value* CertVerifyResultCallback(net::CertVerifyResult verify_result,
+                                      net::NetLog::LogLevel log_level);

[Ryan Sleevi, 2014/05/31 00:53:02]

No need to declare this in the .h file - this is a function internal to the .cc,
so you can let the definition be your declaration.

Sorry I wasn't clearer on that earlier.

[mshelley, 2014/05/31 01:50:39]

Done.

+
 #endif  // NET_CERT_MULTI_THREADED_CERT_VERIFIER_H_
+