Issue 303123011: Fix Linux GN build after crrev.com/273992

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 303123011: Fix Linux GN build after crrev.com/273992 (Closed)

Created:
6 years, 6 months ago by tfarina

Modified:
6 years, 6 months ago

Reviewers:
pilgrim_google, brettw, jam

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix Linux GN build after crrev.com/273992 Looks like before this change went in webkit/common/BUILD.gn was landed and thus when crrev.com/273992 landed they conflicted. This patch removes the resource_devtools_info.* entries from webkit/common/BUILD.gn, since now they were moved into content/content_common.gypi. BUG=338338 TEST=gn gen out/Release_gn --args='is_debug=false' && ninja -C out/Release_gn webkit/common TBR=pilgrim@chromium.org,jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273994

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	webkit/common/BUILD.gn	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tfarina

Committed patchset #1 manually as r273994 (tree was closed).

6 years, 6 months ago (2014-05-31 03:35:27 UTC) #1

Message was sent while issue was closed.

Thanks Thiago!

Expand Messages | Collapse Messages