Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 303123009: [MemSheriff] Widen existing suppression. (Closed)

Created:
6 years, 6 months ago by groby-ooo-7-16
Modified:
6 years, 6 months ago
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@mem_328092
Visibility:
Public.

Description

[MemSheriff] Widen existing suppression. The very first invocation of [NSCursor push]/[NSCursor set] leaks, intentionally. Suppress all invocations for now. ([NSCursor set] only in the suppressions, seems -push seems to get inlined. BUG=257276, 379331 TBR=thestig@chromium.org, shess@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273917

Patch Set 1 #

Patch Set 2 : Re-upload to trigger send-mail #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M tools/valgrind/memcheck/suppressions_mac.txt View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
groby-ooo-7-16
The CQ bit was checked by groby@chromium.org
6 years, 6 months ago (2014-05-30 22:14:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/303123009/20001
6 years, 6 months ago (2014-05-30 22:17:03 UTC) #2
Scott Hess - ex-Googler
lgtm
6 years, 6 months ago (2014-05-30 22:30:53 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 22:37:41 UTC) #4
Message was sent while issue was closed.
Change committed as 273917

Powered by Google App Engine
This is Rietveld 408576698