ARB: Run "gclient sync"

tools/safely-roll-deps.py

 #!/usr/bin/env python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generate a CL to roll a DEPS entry to the specified revision number and post
 it to Rietveld so that the CL will land automatically if it passes the
 commit-queue's checks.
 """
 
@@ skipping 106 matching lines @@
       parser.error('Please delete the branch %s and move to a different branch'
                    % new_branch)
 
   if not options.dry_run:
     prnt_subprocess.check_call(['git', 'fetch', 'origin'])
     prnt_subprocess.call(['git', 'svn', 'fetch'])
     branch_cmd = ['git', 'checkout', '-b', new_branch, options.upstream]
     if options.force:
       branch_cmd.append('-f')
     prnt_subprocess.check_output(branch_cmd)
+    prnt_subprocess.check_call(['gclient', 'sync'])

[borenet, 2014/05/30 13:19:04]

Should I add --nohooks here?

[M-A Ruel, 2014/05/30 14:01:59]

If you are going to sync the whole tree, add this "detail" in the docstring.

But is it necessary? For a bot, it simply increases the points of failures and
hooks run arbitrary code, which doesn't excite me at all. For a user, it's more
useful and hooks should be run.

 
   try:
     old_rev = process_deps(os.path.join(root_dir, 'DEPS'), project, new_rev,
                            options.dry_run)
     print '%s roll %s:%s' % (project.title(), old_rev, new_rev)
 
     review_field = 'TBR' if options.commit else 'R'
     commit_msg = options.message or '%s roll %s:%s\n' % (project.title(),
                                                          old_rev, new_rev)
     commit_msg += '\n%s=%s\n' % (review_field, options.reviewers)
@@ skipping 15 matching lines @@
     prnt_subprocess.check_call(upload_cmd)
   finally:
     if not options.dry_run:
       prnt_subprocess.check_output(['git', 'checkout', old_branch])
       prnt_subprocess.check_output(['git', 'branch', '-D', new_branch])
   return 0
 
 
 if __name__ == '__main__':
   sys.exit(main())