Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(889)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 303123003: new animated sample to show subpixel translate bug with high quality scaling (Closed)

Created:
6 years, 6 months ago by humper
Modified:
6 years, 6 months ago
Reviewers:
robertphillips, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

new animated sample to show subpixel translate bug with high quality scaling BUG=1445 Committed: http://code.google.com/p/skia/source/detail?r=14981

Patch Set 1 #

Total comments: 10

Patch Set 2 : show more rendering modes / scales #

Patch Set 3 : nits from Robert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -0 lines) Patch
M gyp/SampleApp.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A samplecode/SampleSubpixelTranslate.cpp View 1 2 1 chunk +126 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
humper
ptal -- animated sample that definitely demonstrates that there's a noticeable bug here.
6 years, 6 months ago (2014-05-29 21:04:33 UTC) #1
robertphillips
lgtm + nits https://codereview.chromium.org/303123003/diff/1/samplecode/SampleSubpixelTranslate.cpp File samplecode/SampleSubpixelTranslate.cpp (right): https://codereview.chromium.org/303123003/diff/1/samplecode/SampleSubpixelTranslate.cpp#newcode18 samplecode/SampleSubpixelTranslate.cpp:18: // comment - maybe include bug ...
6 years, 6 months ago (2014-05-29 21:18:23 UTC) #2
humper
https://codereview.chromium.org/303123003/diff/1/samplecode/SampleSubpixelTranslate.cpp File samplecode/SampleSubpixelTranslate.cpp (right): https://codereview.chromium.org/303123003/diff/1/samplecode/SampleSubpixelTranslate.cpp#newcode18 samplecode/SampleSubpixelTranslate.cpp:18: On 2014/05/29 21:18:23, robertphillips wrote: > // comment - ...
6 years, 6 months ago (2014-05-29 21:54:51 UTC) #3
humper
The CQ bit was checked by humper@google.com
6 years, 6 months ago (2014-05-29 21:55:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/303123003/40001
6 years, 6 months ago (2014-05-29 21:56:26 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-05-29 22:01:12 UTC) #6
Message was sent while issue was closed. 
Change committed as 14981

Powered by Google App Engine
This is Rietveld 408576698