Issue 303113004: gpu testing: Handle non-integral device pixel ratio.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 303113004: gpu testing: Handle non-integral device pixel ratio. (Closed)

Created:
6 years, 6 months ago by alokp

Modified:
6 years, 6 months ago

Reviewers:
Ken Russell (switch to Gerrit), bajones

CC:
chromium-reviews, piman+watch_chromium.org, jam, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gpu testing: Handle non-integral device pixel ratio. Device pixel ratio is used to scale test rect and sampling locations. It can be non-integral on some devices. For example it is 1.325 on Nexus 7. The scaled quantities - dimensions of screenshot and sampled pixel locations - need to be converted to integers before they can be used. BUG=368495 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273951

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	content/test/gpu/gpu_tests/cloud_storage_test_base.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	content/test/gpu/gpu_tests/gpu_rasterization.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alokp@chromium.org/303113004/1

6 years, 6 months ago (2014-05-30 18:22:38 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...

6 years, 6 months ago (2014-05-30 23:20:44 UTC) #6

Message was sent while issue was closed.

Change committed as 273951

Expand Messages | Collapse Messages