content/test/data/accessibility/button-name-calc-expected-android.txt - Issue 303113003: Properly prioritize the sources of an accessible name on Android.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/accessibility/button-name-calc-expected-android.txt

Issue 303113003: Properly prioritize the sources of an accessible name on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/accessibility/browser_accessibility_android.cc ('K') | « content/browser/accessibility/browser_accessibility_android.cc ('k') | content/test/data/accessibility/checkbox-name-calc-expected-android.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 #<skip - this is definitely wrong

2 android.webkit.WebView focusable focused scrollable	1 android.webkit.WebView focusable focused scrollable

3 android.view.View	2 android.view.View

4 android.widget.Button clickable focusable name='InnerText0'	3 android.widget.Button clickable focusable name='InnerText0'

5 android.widget.Button clickable focusable name='InnerText1'	4 android.widget.Button clickable focusable name='Title1'

6 android.widget.Button clickable focusable name='InnerText2'	5 android.widget.Button clickable focusable name='AriaLabel2'

7 android.widget.Button clickable focusable name='InnerText3'	6 android.widget.Button clickable focusable name='LabelledBy3'

8 android.widget.Button clickable focusable name='InnerText4'	7 android.widget.Button clickable focusable name='LabelledBy4'
	aboxhall 2014/05/30 21:26:21 I'm confused by this: it looks like description ta I'm confused by this: it looks like description takes precedence, but I see this element has aria-describedby. How does that work? dmazzoni 2014/05/30 22:03:33 Dumb luck? I think the behavior is right (labelled Show quoted text On 2014/05/30 21:26:21, aboxhall wrote: > I'm confused by this: it looks like description takes precedence, but I see this > element has aria-describedby. How does that work? Dumb luck? I think the behavior is right (labelledby is more important than describedby if we have to pick one), and the reason it works is because Blink is doing the right thing. What we should really do soon is have Blink try to do less logic and just expose the underlying names, then implement the platform logic here more clearly.
9 android.widget.Button clickable focusable name='InnerText5'	8 android.widget.Button clickable focusable name='DescribedBy5'

OLD	NEW