Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Side by Side Diff: Source/core/inspector/InjectedScriptSource.js

Issue 303113002: Correctly handle object classname and add Symbol type to PropertyPreview and CallArgument in the pr… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/devtools/protocol.json » ('j') | Source/devtools/protocol.json » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Google Inc. All rights reserved. 3 * Copyright (C) 2013 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 1059 matching lines...) Expand 10 before | Expand all | Expand 10 after
1070 1070
1071 return; 1071 return;
1072 } 1072 }
1073 1073
1074 object = /** @type {Object} */ (object); 1074 object = /** @type {Object} */ (object);
1075 1075
1076 this.objectId = injectedScript._bind(object, objectGroupName); 1076 this.objectId = injectedScript._bind(object, objectGroupName);
1077 var subtype = injectedScript._subtype(object); 1077 var subtype = injectedScript._subtype(object);
1078 if (subtype) 1078 if (subtype)
1079 this.subtype = subtype; 1079 this.subtype = subtype;
1080 this.className = InjectedScriptHost.internalConstructorName(object); 1080 var className = InjectedScriptHost.internalConstructorName(object);
1081 if (className)
1082 this.className = className;
1081 this.description = injectedScript._describe(object); 1083 this.description = injectedScript._describe(object);
1082 1084
1083 if (generatePreview && (this.type === "object" || injectedScript._isHTMLAllC ollection(object))) 1085 if (generatePreview && (this.type === "object" || injectedScript._isHTMLAllC ollection(object)))
1084 this.preview = this._generatePreview(object, undefined, columnNames, isT able, false); 1086 this.preview = this._generatePreview(object, undefined, columnNames, isT able, false);
1085 } 1087 }
1086 1088
1087 InjectedScript.RemoteObject.prototype = { 1089 InjectedScript.RemoteObject.prototype = {
1088 /** 1090 /**
1089 * @param {Object} object 1091 * @param {Object} object
1090 * @param {Array.<string>=} firstLevelKeys 1092 * @param {Array.<string>=} firstLevelKeys
(...skipping 538 matching lines...) Expand 10 before | Expand all | Expand 10 after
1629 */ 1631 */
1630 _logEvent: function(event) 1632 _logEvent: function(event)
1631 { 1633 {
1632 inspectedWindow.console.log(event.type, event); 1634 inspectedWindow.console.log(event.type, event);
1633 } 1635 }
1634 } 1636 }
1635 1637
1636 injectedScript._commandLineAPIImpl = new CommandLineAPIImpl(); 1638 injectedScript._commandLineAPIImpl = new CommandLineAPIImpl();
1637 return injectedScript; 1639 return injectedScript;
1638 }) 1640 })
OLDNEW
« no previous file with comments | « no previous file | Source/devtools/protocol.json » ('j') | Source/devtools/protocol.json » ('J')

Powered by Google App Engine
This is Rietveld 408576698