Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 303103002: Remove more ScriptState::current in core/ (Closed)

Created:
6 years, 6 months ago by haraken
Modified:
6 years, 6 months ago
Reviewers:
dcarney, tasak, adamk
CC:
blink-reviews, vsevik+blink_chromium.org, caseq+blink_chromium.org, arv+blink, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, loislo+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, blink-reviews-bindings_chromium.org, Inactive, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Remove more ScriptState::current in core/ ScriptState::current should be called in the binding layer. BUG=357144 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175146

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M Source/bindings/templates/methods.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/ScriptCallStackFactory.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/ScriptCallStackFactory.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/inspector/JavaScriptCallFrame.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/inspector/JavaScriptCallFrame.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/JavaScriptCallFrame.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
haraken
PTAL
6 years, 6 months ago (2014-05-29 07:53:00 UTC) #1
haraken
6 years, 6 months ago (2014-05-29 07:57:36 UTC) #2
adamk
lgtm
6 years, 6 months ago (2014-05-29 18:49:22 UTC) #3
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 6 months ago (2014-05-29 23:17:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/303103002/1
6 years, 6 months ago (2014-05-29 23:18:45 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-05-30 01:00:45 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 15:46:10 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/9636)
6 years, 6 months ago (2014-05-30 15:46:10 UTC) #8
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 6 months ago (2014-05-30 15:47:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/303103002/1
6 years, 6 months ago (2014-05-30 15:48:38 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 15:49:18 UTC) #11
Message was sent while issue was closed.
Change committed as 175146

Powered by Google App Engine
This is Rietveld 408576698