Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 3031006: Add use_system_icu variable to icu.gyp to allow Linux distros to build with s... (Closed)

Created:
10 years, 5 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add use_system_icu variable to icu.gyp to allow Linux distros to build with system ICU. This will require some changes on the browser side to respect USE_SYSTEM_ICU pre-processor symbol, but our bundled ICU code is in a separate repo, so landing here first. TEST=compiles? BUG=28294 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52764

Patch Set 1 #

Total comments: 5

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+450 lines, -404 lines) Patch
M icu.gyp View 1 2 1 chunk +450 lines, -404 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
Please review: jshin: the idea etc mark: gyp
10 years, 5 months ago (2010-07-16 21:38:38 UTC) #1
Mark Mentovai
GYP LG otherwise. http://codereview.chromium.org/3031006/diff/1/2 File icu.gyp (right): http://codereview.chromium.org/3031006/diff/1/2#newcode15 icu.gyp:15: # TODO(mark): Looks like this is ...
10 years, 5 months ago (2010-07-16 21:48:25 UTC) #2
jungshik at Google
10 years, 5 months ago (2010-07-16 22:00:00 UTC) #3
Windows will never have ICU. Mac OS X uses it internally, but ICU is not
exposed.  So, we might shuffle / rearrange conditions around a bit... well, it
doesn't matter, much. 

It looks good to me (+ Mark's comments)

Powered by Google App Engine
This is Rietveld 408576698