src/prettyprinter.cc - Issue 3031005: [Isolates] Avoid dereferencing Isolate::Current() to check oddball identities...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/prettyprinter.cc

Issue 3031005: [Isolates] Avoid dereferencing Isolate::Current() to check oddball identities... (Closed) Base URL: http://v8.googlecode.com/svn/branches/experimental/isolates/

Patch Set: '' Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/prettyprinter.cc

===================================================================

--- src/prettyprinter.cc (revision 5190)

+++ src/prettyprinter.cc (working copy)

@@ -514,13 +514,13 @@

Print("%c", string->Get(i));

}

if (quote) Print("\"");

- } else if (object == HEAP->null_value()) {

+ } else if (object->IsNull()) {

Print("null");

- } else if (object == HEAP->true_value()) {

+ } else if (object->IsTrue()) {

Print("true");

- } else if (object == HEAP->false_value()) {

+ } else if (object->IsFalse()) {

Print("false");

- } else if (object == HEAP->undefined_value()) {

+ } else if (object->IsUndefined()) {

Print("undefined");

} else if (object->IsNumber()) {

Print("%g", object->Number());

« no previous file with comments | « src/objects-inl.h ('k') | src/runtime.cc » ('j') | no next file with comments »