[Isolates] Avoid dereferencing Isolate::Current() to check oddball identities...

src/runtime.cc

 // Copyright 2006-2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 379 matching lines @@
 
 static Object* Runtime_CreateObjectLiteral(Arguments args) {
   HandleScope scope;
   ASSERT(args.length() == 4);
   CONVERT_ARG_CHECKED(FixedArray, literals, 0);
   CONVERT_SMI_CHECKED(literals_index, args[1]);
   CONVERT_ARG_CHECKED(FixedArray, constant_properties, 2);
   CONVERT_SMI_CHECKED(fast_elements, args[3]);
   bool should_have_fast_elements = fast_elements == 1;
 
+  Heap* heap = Isolate::Current()->heap();
+
   // Check if boilerplate exists. If not, create it first.
   Handle<Object> boilerplate(literals->get(literals_index));
-  if (*boilerplate == HEAP->undefined_value()) {
+  if (*boilerplate == heap->undefined_value()) {
     boilerplate = CreateObjectLiteralBoilerplate(literals,
                                                  constant_properties,
                                                  should_have_fast_elements);
     if (boilerplate.is_null()) return Failure::Exception();
     // Update the functions literal and return the boilerplate.
     literals->set(literals_index, *boilerplate);
   }
-  return DeepCopyBoilerplate(HEAP, JSObject::cast(*boilerplate));
+  return DeepCopyBoilerplate(heap, JSObject::cast(*boilerplate));
 }
 
 
 static Object* Runtime_CreateObjectLiteralShallow(Arguments args) {
   HandleScope scope;
   ASSERT(args.length() == 4);
   CONVERT_ARG_CHECKED(FixedArray, literals, 0);
   CONVERT_SMI_CHECKED(literals_index, args[1]);
   CONVERT_ARG_CHECKED(FixedArray, constant_properties, 2);
   CONVERT_SMI_CHECKED(fast_elements, args[3]);
   bool should_have_fast_elements = fast_elements == 1;
 
+  Heap* heap = Isolate::Current()->heap();
+
   // Check if boilerplate exists. If not, create it first.
   Handle<Object> boilerplate(literals->get(literals_index));
-  if (*boilerplate == HEAP->undefined_value()) {
+  if (*boilerplate == heap->undefined_value()) {
     boilerplate = CreateObjectLiteralBoilerplate(literals,
                                                  constant_properties,
                                                  should_have_fast_elements);
     if (boilerplate.is_null()) return Failure::Exception();
     // Update the functions literal and return the boilerplate.
     literals->set(literals_index, *boilerplate);
   }
-  return HEAP->CopyJSObject(JSObject::cast(*boilerplate));
+  return heap->CopyJSObject(JSObject::cast(*boilerplate));
 }
 
 
 static Object* Runtime_CreateArrayLiteral(Arguments args) {
   HandleScope scope;
   ASSERT(args.length() == 3);
   CONVERT_ARG_CHECKED(FixedArray, literals, 0);
   CONVERT_SMI_CHECKED(literals_index, args[1]);
   CONVERT_ARG_CHECKED(FixedArray, elements, 2);
 
+  Heap* heap = Isolate::Current()->heap();
+
   // Check if boilerplate exists. If not, create it first.
   Handle<Object> boilerplate(literals->get(literals_index));
-  if (*boilerplate == HEAP->undefined_value()) {
+  if (*boilerplate == heap->undefined_value()) {
     boilerplate = CreateArrayLiteralBoilerplate(literals, elements);
     if (boilerplate.is_null()) return Failure::Exception();
     // Update the functions literal and return the boilerplate.
     literals->set(literals_index, *boilerplate);
   }
-  return DeepCopyBoilerplate(HEAP, JSObject::cast(*boilerplate));
+  return DeepCopyBoilerplate(heap, JSObject::cast(*boilerplate));
 }
 
 
 static Object* Runtime_CreateArrayLiteralShallow(Arguments args) {
   HandleScope scope;
   ASSERT(args.length() == 3);
   CONVERT_ARG_CHECKED(FixedArray, literals, 0);
   CONVERT_SMI_CHECKED(literals_index, args[1]);
   CONVERT_ARG_CHECKED(FixedArray, elements, 2);
 
+  Heap* heap = Isolate::Current()->heap();
+
   // Check if boilerplate exists. If not, create it first.
   Handle<Object> boilerplate(literals->get(literals_index));
-  if (*boilerplate == HEAP->undefined_value()) {
+  if (*boilerplate == heap->undefined_value()) {
     boilerplate = CreateArrayLiteralBoilerplate(literals, elements);
     if (boilerplate.is_null()) return Failure::Exception();
     // Update the functions literal and return the boilerplate.
     literals->set(literals_index, *boilerplate);
   }
-  return HEAP->CopyJSObject(JSObject::cast(*boilerplate));
+  return heap->CopyJSObject(JSObject::cast(*boilerplate));
 }
 
 
 static Object* Runtime_CreateCatchExtensionObject(Arguments args) {
   ASSERT(args.length() == 2);
   CONVERT_CHECKED(String, key, args[0]);
   Object* value = args[1];
   // Create a catch context extension object.
   JSFunction* constructor =
       Isolate::Current()->context()->global_context()->
@@ skipping 10126 matching lines @@
 #define SETUP_RUNTIME_ENTRIES(Name, argc, resize)                              \
   entries_[lut_index].method = &CodeGenerator::Generate##Name;                 \
   entries_[lut_index].name = "_" #Name;                                        \
   entries_[lut_index++].nargs = argc;
   INLINE_RUNTIME_FUNCTION_LIST(SETUP_RUNTIME_ENTRIES);
 #undef SETUP_RUNTIME_ENTRIES
 }
 
 
 } }  // namespace v8::internal