Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Side by Side Diff: src/ia32/codegen-ia32.cc

Issue 3031005: [Isolates] Avoid dereferencing Isolate::Current() to check oddball identities... (Closed) Base URL: http://v8.googlecode.com/svn/branches/experimental/isolates/
Patch Set: '' Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/heap-inl.h ('k') | src/isolate.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1421 matching lines...) Expand 10 before | Expand all | Expand 10 after
1432 unsigned_left >>= shift_amount; 1432 unsigned_left >>= shift_amount;
1433 } 1433 }
1434 ASSERT(Smi::IsValid(static_cast<int32_t>(unsigned_left))); 1434 ASSERT(Smi::IsValid(static_cast<int32_t>(unsigned_left)));
1435 answer_object = Smi::FromInt(static_cast<int32_t>(unsigned_left)); 1435 answer_object = Smi::FromInt(static_cast<int32_t>(unsigned_left));
1436 break; 1436 break;
1437 } 1437 }
1438 default: 1438 default:
1439 UNREACHABLE(); 1439 UNREACHABLE();
1440 break; 1440 break;
1441 } 1441 }
1442 if (answer_object == HEAP->undefined_value()) { 1442 if (answer_object->IsUndefined()) {
1443 return false; 1443 return false;
1444 } 1444 }
1445 frame_->Push(Handle<Object>(answer_object)); 1445 frame_->Push(Handle<Object>(answer_object));
1446 return true; 1446 return true;
1447 } 1447 }
1448 1448
1449 1449
1450 void CodeGenerator::JumpIfNotBothSmiUsingTypeInfo(Register left, 1450 void CodeGenerator::JumpIfNotBothSmiUsingTypeInfo(Register left,
1451 Register right, 1451 Register right,
1452 Register scratch, 1452 Register scratch,
(...skipping 12350 matching lines...) Expand 10 before | Expand all | Expand 10 after
13803 masm.GetCode(&desc); 13803 masm.GetCode(&desc);
13804 // Call the function from C++. 13804 // Call the function from C++.
13805 return FUNCTION_CAST<MemCopyFunction>(buffer); 13805 return FUNCTION_CAST<MemCopyFunction>(buffer);
13806 } 13806 }
13807 13807
13808 #undef __ 13808 #undef __
13809 13809
13810 } } // namespace v8::internal 13810 } } // namespace v8::internal
13811 13811
13812 #endif // V8_TARGET_ARCH_IA32 13812 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/heap-inl.h ('k') | src/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698