Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 303063002: Transfer texture wrap mode in in cc::Resources (Closed)

Created:
6 years, 6 months ago by ccameron
Modified:
6 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, cc-bugs_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Transfer texture wrap mode in in cc::Resources This is needed for the delegated software renderer. For the GL delegated render, the texture state is maintained by the driver. BUG=314190 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274269

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M cc/resources/resource_provider.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M cc/resources/transferable_resource.h View 1 chunk +1 line, -0 lines 1 comment Download
M cc/resources/transferable_resource.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/common/cc_messages.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
ccameron
ptal https://codereview.chromium.org/303063002/diff/1/cc/resources/transferable_resource.h File cc/resources/transferable_resource.h (right): https://codereview.chromium.org/303063002/diff/1/cc/resources/transferable_resource.h#newcode36 cc/resources/transferable_resource.h:36: bool is_repeated; Alternatively, I could put an enum ...
6 years, 6 months ago (2014-05-29 02:13:54 UTC) #1
enne (OOO)
lgtm
6 years, 6 months ago (2014-05-29 17:49:11 UTC) #2
ccameron
Thanks!
6 years, 6 months ago (2014-05-29 18:26:51 UTC) #3
ccameron
The CQ bit was checked by ccameron@chromium.org
6 years, 6 months ago (2014-05-29 18:27:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/303063002/1
6 years, 6 months ago (2014-05-29 18:30:51 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-05-29 21:45:49 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 21:52:01 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/70495)
6 years, 6 months ago (2014-05-29 21:52:03 UTC) #8
ccameron
Adding cevans for _messages OWNER review
6 years, 6 months ago (2014-05-30 00:55:53 UTC) #9
ccameron
Adding jschuh for message OWNER review
6 years, 6 months ago (2014-05-30 20:32:39 UTC) #10
jschuh
ipc security lgtm (notes: boolean value)
6 years, 6 months ago (2014-06-02 16:30:45 UTC) #11
ccameron
Thanks!
6 years, 6 months ago (2014-06-02 17:30:01 UTC) #12
ccameron
The CQ bit was checked by ccameron@chromium.org
6 years, 6 months ago (2014-06-02 17:30:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/303063002/1
6 years, 6 months ago (2014-06-02 17:31:00 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 17:35:11 UTC) #15
Message was sent while issue was closed.
Change committed as 274269

Powered by Google App Engine
This is Rietveld 408576698