Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: tools/telemetry/telemetry/core/tab_unittest.py

Issue 303043002: Refactor all video related processing to its own class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing speedindex tests and resync Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/core/tab.py ('k') | tools/telemetry/telemetry/core/video.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/tab_unittest.py
diff --git a/tools/telemetry/telemetry/core/tab_unittest.py b/tools/telemetry/telemetry/core/tab_unittest.py
index 09815fd44c33b199ef8f84ce6cd070a336642e52..dec5fb1e8d61f92b99faed1f340e18fc8199f688 100644
--- a/tools/telemetry/telemetry/core/tab_unittest.py
+++ b/tools/telemetry/telemetry/core/tab_unittest.py
@@ -6,6 +6,7 @@ import logging
from telemetry import test
from telemetry.core import bitmap
+from telemetry.core import video
from telemetry.core import util
from telemetry.core import exceptions
from telemetry.core.backends.chrome import tracing_backend
@@ -27,7 +28,7 @@ class FakePlatform(object):
def StopVideoCapture(self):
self._is_video_capture_running = False
- return []
+ return video.Video(self, None)
def SetFullPerformanceModeEnabled(self, enabled):
pass
@@ -89,10 +90,7 @@ class TabTest(tab_test_case.TabTestCase):
self.assertFalse(self._tab.is_video_capture_running)
self._tab.StartVideoCapture(min_bitrate_mbps=2)
self.assertTrue(self._tab.is_video_capture_running)
- try:
- self._tab.StopVideoCapture().next()
- except Exception:
- pass
+ self.assertIsNotNone(self._tab.StopVideoCapture())
self.assertFalse(self._tab.is_video_capture_running)
self._tab.browser._platform = original_platform
« no previous file with comments | « tools/telemetry/telemetry/core/tab.py ('k') | tools/telemetry/telemetry/core/video.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698