Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: tools/telemetry/telemetry/core/platform/__init__.py

Issue 303043002: Refactor all video related processing to its own class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing speedindex tests and resync Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/platform/__init__.py
diff --git a/tools/telemetry/telemetry/core/platform/__init__.py b/tools/telemetry/telemetry/core/platform/__init__.py
index db7e7c299b287caa4832d70f3602e57949904754..70c423f7f773a3f40ee82ffa5b7519b4f3908fb6 100644
--- a/tools/telemetry/telemetry/core/platform/__init__.py
+++ b/tools/telemetry/telemetry/core/platform/__init__.py
@@ -165,14 +165,10 @@ class Platform(object):
def StopVideoCapture(self):
"""Stops capturing video.
- Yields:
- (time_ms, bitmap) tuples representing each video keyframe. Only the first
- frame in a run of sequential duplicate bitmaps is included.
- time_ms is milliseconds relative to the first frame.
- bitmap is a telemetry.core.Bitmap.
+ Returns:
+ A telemetry.core.video.Video object.
"""
- for t in self._platform_backend.StopVideoCapture():
- yield t
+ return self._platform_backend.StopVideoCapture()
def CanMonitorPower(self):
"""Returns True iff power can be monitored asynchronously via
« no previous file with comments | « tools/perf/metrics/speedindex_unittest.py ('k') | tools/telemetry/telemetry/core/platform/android_platform_backend.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698