tools/perf/metrics/speedindex.py - Issue 303043002: Refactor all video related processing to its own class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/metrics/speedindex.py

Issue 303043002: Refactor all video related processing to its own class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing speedindex tests and resync Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/metrics/speedindex.py

diff --git a/tools/perf/metrics/speedindex.py b/tools/perf/metrics/speedindex.py

index ab3068df5422a1f68c46b2e3673d515ae0308070..1b270397a5e5a9cf8c2f158007b72487cdaf2beb 100644

--- a/tools/perf/metrics/speedindex.py

+++ b/tools/perf/metrics/speedindex.py

@@ -138,9 +138,10 @@ class VideoSpeedIndexImpl(SpeedIndexImpl):

# previous page to white. The tolerance of 8 experimentally does well with

# video capture at 4mbps. We should keep this as low as possible with

# supported video compression settings.

+ video_capture = tab.StopVideoCapture()

histograms = [(time, bmp.ColorHistogram(ignore_color=bitmap.WHITE,

tolerance=8))

- for time, bmp in tab.StopVideoCapture()]

+ for time, bmp in video_capture.GetVideoFrameIter()]

start_histogram = histograms[0][1]

final_histogram = histograms[-1][1]

« no previous file with comments | « no previous file | tools/perf/metrics/speedindex_unittest.py » ('j') | no next file with comments »