Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 303033004: Enable Skia discardable memory path on Android (Closed)

Created:
6 years, 6 months ago by Alpha Left Google
Modified:
6 years, 6 months ago
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis, reveman
Visibility:
Public.

Description

Enable Skia discardable memory path on Android With this change Android will stop using the old discardable memory path and will use Skia's implementation of discardable memory and caching. Tested on Android with ChromeShell. BUG=169282

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -54 lines) Patch
M Source/platform/graphics/DeferredImageDecoder.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/platform/graphics/DeferredImageDecoder.cpp View 5 chunks +6 lines, -51 lines 2 comments Download

Messages

Total messages: 10 (0 generated)
Alpha Left Google
6 years, 6 months ago (2014-05-29 01:54:08 UTC) #1
reveman
lgtm +pliard fyi https://codereview.chromium.org/303033004/diff/1/Source/platform/graphics/DeferredImageDecoder.cpp File Source/platform/graphics/DeferredImageDecoder.cpp (right): https://codereview.chromium.org/303033004/diff/1/Source/platform/graphics/DeferredImageDecoder.cpp#newcode275 Source/platform/graphics/DeferredImageDecoder.cpp:275: #if SK_B32_SHIFT // Little-endian RGBA pixels. ...
6 years, 6 months ago (2014-05-29 03:30:54 UTC) #2
Alpha Left Google
On 2014/05/29 03:30:54, reveman wrote: > lgtm > > +pliard fyi > > https://codereview.chromium.org/303033004/diff/1/Source/platform/graphics/DeferredImageDecoder.cpp > ...
6 years, 6 months ago (2014-05-29 07:32:19 UTC) #3
Alpha Left Google
ping senorblanco.
6 years, 6 months ago (2014-05-29 19:28:40 UTC) #4
Stephen White
LGTM https://codereview.chromium.org/303033004/diff/1/Source/platform/graphics/DeferredImageDecoder.cpp File Source/platform/graphics/DeferredImageDecoder.cpp (left): https://codereview.chromium.org/303033004/diff/1/Source/platform/graphics/DeferredImageDecoder.cpp#oldcode277 Source/platform/graphics/DeferredImageDecoder.cpp:277: // legacy LazyDecodingPixelRef. Out of curiosity, does this ...
6 years, 6 months ago (2014-05-29 20:07:43 UTC) #5
Alpha Left Google
On 2014/05/29 20:07:43, Stephen White wrote: > LGTM > > https://codereview.chromium.org/303033004/diff/1/Source/platform/graphics/DeferredImageDecoder.cpp > File Source/platform/graphics/DeferredImageDecoder.cpp (left): ...
6 years, 6 months ago (2014-05-30 19:06:24 UTC) #6
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 6 months ago (2014-05-30 19:06:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/303033004/1
6 years, 6 months ago (2014-05-30 19:07:45 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-05-30 21:01:21 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 22:53:27 UTC) #10
Message was sent while issue was closed.
Change committed as 175166

Powered by Google App Engine
This is Rietveld 408576698