Mac: Enable help when there are no windows.

Mac: Enable help when there are no windows.

BUG=23825
TEST=Close all browser windows. Check that Help->Chromium Help (or Google Chrome Help) is enabled and works correctly.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29744

[Miranda Callahan, 2009-10-22 00:21:40]

LGTM!

On 2009/10/22 00:19:02, viettrungluu wrote:
>

[pink (ping after 24hrs), 2009-10-22 18:22:55]

drive-by

http://codereview.chromium.org/303030/diff/1/3
File chrome/browser/browser.cc (right):

http://codereview.chromium.org/303030/diff/1/3#newcode324
Line 324: void Browser::OpenHelpWindow(Profile* profile) {
we don't follow this pattern for anything else (themes, about license, etc etc).
Should we unify everything to this way?

[viettrungluu, 2009-10-23 02:50:50]

On 2009/10/22 18:22:55, pink wrote:
> drive-by
> 
> http://codereview.chromium.org/303030/diff/1/3
> File chrome/browser/browser.cc (right):
> 
> http://codereview.chromium.org/303030/diff/1/3#newcode324
> Line 324: void Browser::OpenHelpWindow(Profile* profile) {
> we don't follow this pattern for anything else (themes, about license, etc
etc).
> Should we unify everything to this way?

My logic was that, since there's a Browser::OpenHelpTab(), there should be a
corresponding OpenHelpWindow(). It might make sense and help organize things to
unify everything this way.

Probably the ShowXYZTab() methods also need corresponding OpenXYZWindow()
methods (where XYZ = History, Downloads).