Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Unified Diff: chrome/browser/omnibox/omnibox_field_trial.h

Issue 303013002: Omnibox: Create Disable-Inlining Experiment (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: adds test Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/omnibox/omnibox_field_trial.h
diff --git a/chrome/browser/omnibox/omnibox_field_trial.h b/chrome/browser/omnibox/omnibox_field_trial.h
index 1b0a1c74c08edd0cb45309e44e65c810416e101c..832067dc1ec7be89c97e39a313069728bbedfa61 100644
--- a/chrome/browser/omnibox/omnibox_field_trial.h
+++ b/chrome/browser/omnibox/omnibox_field_trial.h
@@ -270,6 +270,18 @@ class OmniboxFieldTrial {
static bool BookmarksIndexURLsValue();
// ---------------------------------------------------------
+ // For the DisableInlining experiment that's part of the bundled omnibox
+ // field trial.
+
+ // Returns true if AutocompleteResult should prevent any suggestion with
+ // a non-empty |inline_autocomplete| from being the default match. In
+ // other words, prevent an inline autocompletion from appearing as the
+ // top suggestion / within the omnibox itself, reordering matches as
+ // necessary to make this true. Returns false if the experiment isn't
+ // active.
+ static bool DisableInlining();
+
+ // ---------------------------------------------------------
// Exposed publicly for the sake of unittests.
static const char kBundledExperimentFieldTrialName[];
// Rule names used by the bundled experiment.
@@ -283,6 +295,7 @@ class OmniboxFieldTrial {
static const char kZeroSuggestRule[];
static const char kZeroSuggestVariantRule[];
static const char kBookmarksIndexURLsRule[];
+ static const char kDisableInliningRule[];
// Parameter names used by the HUP new scoring experiments.
static const char kHUPNewScoringEnabledParam[];

Powered by Google App Engine
This is Rietveld 408576698