Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 303012: Fix bubbles deactivating the opaque frame.... (Closed)

Created:
11 years, 2 months ago by Ben Goodger (Google)
Modified:
9 years, 6 months ago
Reviewers:
Glen Murphy
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

Fix bubbles deactivating the opaque frame. The theme work caused a check that had been included to see if the frame view should be painted as active even if it was inactive. This reintroduces that check. http://crbug.com/20966 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29571

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M chrome/browser/views/frame/opaque_browser_frame_view.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M views/window/non_client_view.h View 2 chunks +7 lines, -2 lines 0 comments Download
M views/window/non_client_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
11 years, 2 months ago (2009-10-20 20:07:07 UTC) #1
Glen Murphy
11 years, 2 months ago (2009-10-20 20:08:41 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698