Issue 303006: Delete unused themes from disk on shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 303006: Delete unused themes from disk on shutdown. (Closed)

Created:
11 years, 2 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Glen Murphy, Miranda Callahan, Aaron Boodman

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Delete unused themes from disk on shutdown. This reduces the size of the Preferences file and frees up some disk space. The smaller Preferences file should help improve startup time for users who have installed lots of themes. BUG=24377 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29468

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -2 lines)			Patch
M	chrome/browser/browser_theme_provider.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_theme_provider.cc	View	4 chunks	+23 lines, -1 line	0 comments	Download
M	chrome/browser/profile.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/extensions/extension.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Miranda Callahan

LGTM. Thanks for changing the SavePersistentPrefs, and also especially the helpful comment in profile.cc. On ...

11 years, 2 months ago (2009-10-19 22:01:25 UTC) #2

lgtm

Expand Messages | Collapse Messages