Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Side by Side Diff: chrome/browser/utility_process_host.cc

Issue 3030043: PrependWrapper is platform-specific, so it should take a platform string. (Closed)
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/utility_process_host.h" 5 #include "chrome/browser/utility_process_host.h"
6 6
7 #include "app/app_switches.h" 7 #include "app/app_switches.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/file_util.h" 9 #include "base/file_util.h"
10 #include "base/message_loop.h" 10 #include "base/message_loop.h"
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 cmd_line->AppendSwitch(switches::kIssue35198ExtraLogging); 102 cmd_line->AppendSwitch(switches::kIssue35198ExtraLogging);
103 103
104 #if defined(OS_POSIX) 104 #if defined(OS_POSIX)
105 // TODO(port): Sandbox this on Linux. Also, zygote this to work with 105 // TODO(port): Sandbox this on Linux. Also, zygote this to work with
106 // Linux updating. 106 // Linux updating.
107 bool has_cmd_prefix = browser_command_line.HasSwitch( 107 bool has_cmd_prefix = browser_command_line.HasSwitch(
108 switches::kUtilityCmdPrefix); 108 switches::kUtilityCmdPrefix);
109 if (has_cmd_prefix) { 109 if (has_cmd_prefix) {
110 // launch the utility child process with some prefix (usually "xterm -e gdb 110 // launch the utility child process with some prefix (usually "xterm -e gdb
111 // --args"). 111 // --args").
112 cmd_line->PrependWrapper(browser_command_line.GetSwitchValue( 112 cmd_line->PrependWrapper(browser_command_line.GetSwitchValueNative(
113 switches::kUtilityCmdPrefix)); 113 switches::kUtilityCmdPrefix));
114 } 114 }
115 115
116 cmd_line->AppendSwitchPath(switches::kUtilityProcessAllowedDir, exposed_dir); 116 cmd_line->AppendSwitchPath(switches::kUtilityProcessAllowedDir, exposed_dir);
117 #endif 117 #endif
118 118
119 Launch( 119 Launch(
120 #if defined(OS_WIN) 120 #if defined(OS_WIN)
121 exposed_dir, 121 exposed_dir,
122 #elif defined(OS_POSIX) 122 #elif defined(OS_POSIX)
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 IPC_MESSAGE_HANDLER(UtilityHostMsg_ParseUpdateManifest_Succeeded, 154 IPC_MESSAGE_HANDLER(UtilityHostMsg_ParseUpdateManifest_Succeeded,
155 Client::OnParseUpdateManifestSucceeded) 155 Client::OnParseUpdateManifestSucceeded)
156 IPC_MESSAGE_HANDLER(UtilityHostMsg_ParseUpdateManifest_Failed, 156 IPC_MESSAGE_HANDLER(UtilityHostMsg_ParseUpdateManifest_Failed,
157 Client::OnParseUpdateManifestFailed) 157 Client::OnParseUpdateManifestFailed)
158 IPC_MESSAGE_HANDLER(UtilityHostMsg_DecodeImage_Succeeded, 158 IPC_MESSAGE_HANDLER(UtilityHostMsg_DecodeImage_Succeeded,
159 Client::OnDecodeImageSucceeded) 159 Client::OnDecodeImageSucceeded)
160 IPC_MESSAGE_HANDLER(UtilityHostMsg_DecodeImage_Failed, 160 IPC_MESSAGE_HANDLER(UtilityHostMsg_DecodeImage_Failed,
161 Client::OnDecodeImageFailed) 161 Client::OnDecodeImageFailed)
162 IPC_END_MESSAGE_MAP_EX() 162 IPC_END_MESSAGE_MAP_EX()
163 } 163 }
OLDNEW
« no previous file with comments | « chrome/browser/renderer_host/browser_render_process_host.cc ('k') | chrome/browser/worker_host/worker_process_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698