Issue 3030043: PrependWrapper is platform-specific, so it should take a platform string.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3030043: PrependWrapper is platform-specific, so it should take a platform string. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by Evan Martin

Modified:
4 years ago

Reviewers:
tony, tonyg

CC:
chromium-reviews, jam, Paweł Hajdan Jr., ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Visibility:
Public.

Description

PrependWrapper is platform-specific, so it should take a platform string. Though the comments said it was POSIX only, I see it used on Windows as well so I'm updating the comment. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54933

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -24 lines)			Patch
M	base/command_line.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	base/command_line.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/gpu_process_host.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/plugin_process_host.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/utility_process_host.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/worker_host/worker_process_host.cc	View	1 chunk	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/zygote_host_linux.cc	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/test/ui/ui_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Trybot results: mac win linux

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages