Use built-in size function from std::string instead of strlen function.

Use built-in size function from std::string instead of strlen function.

This was missed in another review at
http://codereview.chromium.org/3043018/diff/22001/23009#newcode28, noticed by
viettrungluu.

BUG=None
TEST=trybots

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55181

[tfarina, 2010-08-01 19:36:13]

http://codereview.chromium.org/3030035/diff/1/2
File chrome/plugin/plugin_main_mac.mm (right):

http://codereview.chromium.org/3030035/diff/1/2#newcode36
chrome/plugin/plugin_main_mac.mm:36: strcmp(interpose_list.c_str() +
suffix_offset,
how can I fix this trungl?

[tfarina, 2010-08-03 03:16:16]

friendly ping.

[viettrungluu, 2010-08-03 05:56:46]

http://codereview.chromium.org/3030035/diff/1/2
File chrome/plugin/plugin_main_mac.mm (right):

http://codereview.chromium.org/3030035/diff/1/2#newcode28
chrome/plugin/plugin_main_mac.mm:28: int suffix_offset =
static_cast<int>(interpose_list.size() -
The suffix_offset better not be negative. Casting to an int is wrong. Besides
which, both .size() and strlen() return size_t's. But you should DCHECK() that
.size() > strlen(). But also see below.

http://codereview.chromium.org/3030035/diff/1/2#newcode32
chrome/plugin/plugin_main_mac.mm:32: strcmp(interpose_list.c_str(),
You should also avoid this .c_str(). In fact, you may as well put
plugin_interpose_strings::kInterposeLibraryPath into an std::string above. Then
you could also avoid the strlen() above.

http://codereview.chromium.org/3030035/diff/1/2#newcode36
chrome/plugin/plugin_main_mac.mm:36: strcmp(interpose_list.c_str() +
suffix_offset,
On 2010/08/01 19:36:13, tfarina wrote:
> how can I fix this trungl?

Something like "interpose_list.substr(suffix_offset) ==
plugin_interpose_strings::kInterposeLibraryPath"; please make sure this works.

http://codereview.chromium.org/3030035/diff/1/2#newcode39
chrome/plugin/plugin_main_mac.mm:39:
env->SetEnv(plugin_interpose_strings::kDYLDInsertLibrariesKey,
You should also make SetEnv() (or whatever it's renamed to able to take
std::strings.

[tfarina, 2010-08-03 14:06:05]

Please, take another look.

[viettrungluu, 2010-08-05 04:17:39]

LGTM.

http://codereview.chromium.org/3030035/diff/6001/7001
File chrome/plugin/plugin_main_mac.mm (right):

http://codereview.chromium.org/3030035/diff/6001/7001#newcode30
chrome/plugin/plugin_main_mac.mm:30: size_t suffix_offset =
interpose_list.size() - interpose_library_path.size();
Please DCHECK_GE(interpose_list.size(), interpose_library_path.size());

[tfarina, 2010-08-05 04:25:18]

http://codereview.chromium.org/3030035/diff/6001/7001
File chrome/plugin/plugin_main_mac.mm (right):

http://codereview.chromium.org/3030035/diff/6001/7001#newcode30
chrome/plugin/plugin_main_mac.mm:30: size_t suffix_offset =
interpose_list.size() - interpose_library_path.size();
On 2010/08/05 04:17:39, viettrungluu wrote:
> Please DCHECK_GE(interpose_list.size(), interpose_library_path.size());

Done.