Issue 3030033: Flip the default for the cookie prompt to disabled.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3030033: Flip the default for the cookie prompt to disabled. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by jochen

Modified:
4 years ago

Reviewers:
viettrungluu

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Flip the default for the cookie prompt to disabled. BUG=50083 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54461

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -20 lines)			Patch
M	chrome/browser/cocoa/content_blocked_bubble_controller.mm	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/cocoa/content_exceptions_window_controller.mm	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/cocoa/content_settings_dialog_controller.mm	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/content_setting_bubble_model.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/content_setting_combo_model.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/options/cookie_filter_page_gtk.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/host_content_settings_map.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/views/options/content_filter_page_view.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Trybot results: linux_view win linux mac

Total messages: 1 (0 generated)

viettrungluu

4 years, 10 months ago (2010-07-31 18:41:13 UTC) #1

LGTM.

Maybe we should consider adding built-in support for --enable-.../--disable-...
to our command-line class.