Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Unified Diff: pkg/polymer/test/build/script_compactor_test.dart

Issue 303003003: Fix 19029: handle special case when on-handler is empty in polymer, add better (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/polymer/test/build/script_compactor_test.dart
diff --git a/pkg/polymer/test/build/script_compactor_test.dart b/pkg/polymer/test/build/script_compactor_test.dart
index a2dc1c672ae43be40adcb1acdba54d166e3aaba7..9220c46fda2b60bb36b0db7a5631ade17a212b53 100644
--- a/pkg/polymer/test/build/script_compactor_test.dart
+++ b/pkg/polymer/test/build/script_compactor_test.dart
@@ -656,15 +656,17 @@ codegenTests(phases) {
'<div>{{anotherNode}}</div>'
'<div>{{a.call1(a)}}</div>'
'<div>{{call2(a)}}</div>'
+ '<div>{{}}</div>'
'<div class="{{an.attribute}}"></div>'
'<a href="path/{{within.an.attribute}}/foo/bar"></a>'
'<div data-attribute="{{anotherAttribute}}"></div>'
// input and custom-element attributes are treated as 2-way bindings:
- '<input value="{{this.is.twoWay}}">'
- '<input value="{{this.is.twoWayInt | intToStringTransformer}}">'
+ '<input value="{{this.iS.twoWay}}">'
Siggi Cherem (dart-lang) 2014/05/29 00:05:18 "is" is a reserved word, so now smoke made this pa
Jennifer Messerly 2014/05/29 00:27:42 interesting! longer term we might have an issue th
+ '<input value="{{this.iS.twoWayInt | intToStringTransformer}}">'
'<something-else my-attribute="{{here.too}}"></something-else>'
'<div on-click="{{methodName}}"></div>'
'<div on-click="{{@read.method}}"></div>'
+ '<div on-click="{{}}"></div>'
'</template></polymer-element>',
'a|web/test.html._data': expectedData(['web/a.dart']),
'a|web/a.dart':
@@ -689,8 +691,8 @@ codegenTests(phases) {
#call1: (o) => o.call1,
#call2: (o) => o.call2,
#here: (o) => o.here,
+ #iS: (o) => o.iS,
#intToStringTransformer: (o) => o.intToStringTransformer,
- #is: (o) => o.is,
#method: (o) => o.method,
#methodName: (o) => o.methodName,
#node: (o) => o.node,
@@ -714,8 +716,8 @@ codegenTests(phases) {
#call1: r'call1',
#call2: r'call2',
#here: r'here',
+ #iS: r'iS',
#intToStringTransformer: r'intToStringTransformer',
- #is: r'is',
#method: r'method',
#methodName: r'methodName',
#node: r'node',

Powered by Google App Engine
This is Rietveld 408576698