Fix 19029: handle special case when on-handler is empty in polymer, add better

pkg/smoke/test/codegen/generator_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library smoke.test.codegen.generator_test;
 
 import 'package:smoke/codegen/generator.dart';
 import 'package:unittest/unittest.dart';
 
 import 'common.dart' show checkResults;
@@ skipping 36 matching lines @@
         '    setters: {\n'
         '      #foo: (o, v) { o.foo = v; },\n'
         '      #i: (o, v) { o.i = v; },\n'
         '    }));\n');
   });
 
   test('names/symbols', () {
     var generator = new SmokeCodeGenerator();
     generator.addSymbol('i');
     generator.addSymbol('foo');
+    generator.addSymbol('a.b.c');
+    generator.addSymbol('a.b.[]');
+    generator.addSymbol('[]');
+    generator.addSymbol('+');
     checkResults(generator, initCall:
         'useGeneratedCode(new StaticConfiguration(\n'
         '    checkedMode: false,\n'
         '    names: {\n'
+        '      const Symbol(\'+\'): r\'+\',\n'
+        '      const Symbol(\'[]\'): r\'[]\',\n'
+        '      const Symbol(\'a.b.[]\'): r\'a.b.[]\',\n'
+        '      #a.b.c: r\'a.b.c\',\n'
         '      #foo: r\'foo\',\n'
         '      #i: r\'i\',\n'
         '    }));\n');
   });
 
+  group('invalid symbols', () {
+    var invalidError =
+        predicate((e) => e is StateError && '$e'.contains("invalid symbol"));
+    test('traling period', () {
+      var generator = new SmokeCodeGenerator();
+      generator.addSymbol('a.');
+      var sb = new StringBuffer();
+      expect(() => generator.writeInitCall(sb), throwsA(invalidError));
+    });
+
+    test('operator in the middle', () {
+      var generator = new SmokeCodeGenerator();
+      generator.addSymbol('a.[].b');
+      var sb = new StringBuffer();
+      expect(() => generator.writeInitCall(sb), throwsA(invalidError));
+    });
+  });
+
   test('getters, setters, and names', () {
     var generator = new SmokeCodeGenerator();
     generator.addGetter('i');
     generator.addSetter('i');
     generator.addSetter('foo');
     generator.addSymbol('foo');
     checkResults(generator, initCall:
         'useGeneratedCode(new StaticConfiguration(\n'
         '    checkedMode: false,\n'
         '    getters: {\n'
@@ skipping 116 matching lines @@
           '      smoke_0.A: {\n'
           '        #foo: const Declaration(#foo, int, isFinal: true),\n'
           '      },\n'
           '    },\n'
           '    names: {\n'
           '      #c: r\'c\',\n'
           '      #d: r\'d\',\n'
           '    }));\n');
   });
 }