Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Unified Diff: chrome/browser/resources/google_now/manifest.json

Issue 303003002: Restrict Google Now URL Permissions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/google_now/manifest.json
diff --git a/chrome/browser/resources/google_now/manifest.json b/chrome/browser/resources/google_now/manifest.json
index 8ee0ae244008a7158883aadb24080ecb9d3a6471..1eb6e9111076150bc34740b611115f068e6e2da9 100644
--- a/chrome/browser/resources/google_now/manifest.json
+++ b/chrome/browser/resources/google_now/manifest.json
@@ -18,9 +18,10 @@
"storage",
"tabs",
"webstorePrivate",
- // TODO(vadimt): Replace <all_urls> with real URL patterns once we know
- // them.
- "<all_urls>"
+ "*://*.google.com/*",
skare_ 2014/05/29 18:28:53 overall I'd be more worried about blocking somethi
robliao 2014/05/29 18:53:50 Issue discussed. On 2014/05/29 18:28:53, Travis Sk
+ "*://*.gstatic.com/*",
+ "https://*.googleapis.com/chromenow/v1/*",
+ "https://*.googleusercontent.com/*"
rgustafson 2014/05/29 17:30:01 Did you find something that suggested that restaur
robliao 2014/05/29 17:35:19 Nope. The images I got back from my tests are eith
],
"optional_permissions": ["background"],
"manifest_version": 2,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698