Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 302943002: DevTools: add device selector and touch checkbox into the responsive toolbar. (Closed)

Created:
6 years, 6 months ago by pfeldman
Modified:
6 years, 6 months ago
Reviewers:
dgozman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: add device selector and touch checkbox into the responsive toolbar. NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175051

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1

Patch Set 5 : #

Patch Set 6 : Rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+558 lines, -206 lines) Patch
M Source/devtools/devtools.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A Source/devtools/front_end/Images/responsiveDesign.png View 1 2 3 Binary file 0 comments Download
A Source/devtools/front_end/Images/responsiveDesign_2x.png View 1 2 Binary file 0 comments Download
A Source/devtools/front_end/Images/src/responsiveDesign.svg View 1 2 1 chunk +210 lines, -0 lines 0 comments Download
M Source/devtools/front_end/ResponsiveDesignView.js View 1 2 2 chunks +55 lines, -9 lines 0 comments Download
M Source/devtools/front_end/elements/OverridesView.js View 6 chunks +7 lines, -169 lines 0 comments Download
M Source/devtools/front_end/responsiveDesignView.css View 1 2 3 4 5 chunks +92 lines, -24 lines 0 comments Download
M Source/devtools/front_end/sdk/OverridesSupport.js View 1 2 3 4 5 5 chunks +192 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
pfeldman
6 years, 6 months ago (2014-05-28 21:11:08 UTC) #1
dgozman
lgtm https://codereview.chromium.org/302943002/diff/60001/Source/devtools/front_end/ResponsiveDesignView.js File Source/devtools/front_end/ResponsiveDesignView.js (right): https://codereview.chromium.org/302943002/diff/60001/Source/devtools/front_end/ResponsiveDesignView.js#newcode389 Source/devtools/front_end/ResponsiveDesignView.js:389: WebInspector.overridesSupport.emulateDevice(option.metrics, option.userAgent); Will not this trigger updateDeviceCheckboxStatus multiple ...
6 years, 6 months ago (2014-05-29 07:57:48 UTC) #2
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 6 months ago (2014-05-29 10:20:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/302943002/100001
6 years, 6 months ago (2014-05-29 10:22:23 UTC) #4
pfeldman
The CQ bit was unchecked by pfeldman@chromium.org
6 years, 6 months ago (2014-05-29 11:26:40 UTC) #5
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 6 months ago (2014-05-29 11:26:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/302943002/100001
6 years, 6 months ago (2014-05-29 11:27:11 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-05-29 11:28:23 UTC) #8
Message was sent while issue was closed.
Change committed as 175051

Powered by Google App Engine
This is Rietveld 408576698